Commit 3fe283f
committed
feat: deprecation notice for enum cases missing #[EnumValue]
Announces the upcoming opt-in migration for PHP enums mapped to GraphQL
enum types. Today every case is automatically exposed; a future major
release will require #[EnumValue] on each case that should participate
in the schema, matching the opt-in model #[Field] already uses for
methods and properties on object types.
The practical win is selective exposure: an internal enum case can opt
out of the public schema simply by omitting #[EnumValue], instead of
forcing schema authors to split an enum or rename cases.
Runtime behaviour is unchanged. When an enum annotated with #[Type]
exposes any case without an #[EnumValue] attribute, EnumTypeMapper
emits an E_USER_DEPRECATED notice that names the specific cases so the
migration path is mechanical — matching graphqlite's existing
deprecation pattern (e.g. addControllerNamespace, setGlobTTL).
Tests: +1 explicit deprecation assertion (using PHPUnit 11's
expectUserDeprecationMessageMatches). Existing integration tests that
exercise the Genre fixture surface the notice via PHPUnit's deprecation
reporting, confirming the warning fires in realistic scenarios. Full
suite 538/538 green across cs-check, phpstan, and phpunit; 4 intentional
deprecation events reported.
Docs: descriptions.md gains a "Future migration" subsection describing
the planned opt-in model and the current advisory notice.1 parent cc04b22 commit 3fe283f
3 files changed
Lines changed: 78 additions & 0 deletions
File tree
- src/Mappers/Root
- tests/Integration
- website/docs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
34 | 39 | | |
35 | 40 | | |
36 | 41 | | |
| |||
143 | 148 | | |
144 | 149 | | |
145 | 150 | | |
| 151 | + | |
| 152 | + | |
146 | 153 | | |
147 | 154 | | |
148 | 155 | | |
149 | 156 | | |
150 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
151 | 162 | | |
152 | 163 | | |
153 | 164 | | |
| |||
172 | 183 | | |
173 | 184 | | |
174 | 185 | | |
| 186 | + | |
| 187 | + | |
175 | 188 | | |
176 | 189 | | |
177 | 190 | | |
178 | 191 | | |
179 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
180 | 225 | | |
181 | 226 | | |
182 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
108 | 122 | | |
109 | 123 | | |
110 | 124 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
132 | 151 | | |
133 | 152 | | |
134 | 153 | | |
| |||
0 commit comments