fix: allow adding properties starting with 'set' (#779)

* fix: allow adding properties starting with 'set'

Now legitimate properties with prefix 'set' are cut.
Such as 'settled', 'settings', 'setup'...
Also, all setters are cut out despite the presence
of an explicit 'Field' indication.
This shouldn't break backwards compatibility because
it requires explicitly specifying 'Field' attribute.

* test: check presence of field with 'set' prefix

Checks whether fields that begin with 'set' have been
lost as a result of constructing the schema.

---------

Co-authored-by: ex-sh <[email protected]>

Author: supresys

src/FieldsBuilder.php

@@ -444,9 +444,6 @@ private function getFieldsByMethodAnnotations(
             $methodName = $refMethod->getName();
 
             if ($queryAnnotation instanceof Field) {
-                if (str_starts_with($methodName, 'set')) {
-                    continue;
-                }
                 $for = $queryAnnotation->getFor();
                 if ($typeName && $for && ! in_array($typeName, $for)) {
                     continue;

tests/FieldsBuilderTest.php

@@ -60,6 +60,7 @@
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithMagicProperty;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithMagicPropertyType;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithPrefetchMethods;
+use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithSetPrefix;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithSourceFieldInterface;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithSourceFieldInvalidParameterAnnotation;
 use TheCodingMachine\GraphQLite\Mappers\CannotMapTypeException;
@@ -440,6 +441,16 @@ public function testSourceFieldIsId(): void
         $this->assertInstanceOf(IDType::class, $fields['test']->getType()->getWrappedType());
     }
 
+    public function testFieldWithSetPrefixPresence(): void
+    {
+        $queryProvider = $this->buildFieldsBuilder();
+        $fields = $queryProvider->getFields(new TestTypeWithSetPrefix());
+        $this->assertCount(2, $fields);
+
+        $this->assertSame('settings', $fields['settings']->name);
+        $this->assertSame('numberOfParameters', $fields['numberOfParameters']->name);
+    }
+
     public function testFromSourceFieldsInterface(): void
     {
         $queryProvider = new FieldsBuilder(

tests/Fixtures/TestTypeWithSetPrefix.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TheCodingMachine\GraphQLite\Fixtures;
+
+use TheCodingMachine\GraphQLite\Annotations\Field;
+use TheCodingMachine\GraphQLite\Annotations\Type;
+
+#[Type(class: TestObject::class)]
+class TestTypeWithSetPrefix
+{
+    #[Field]
+    public function settings(): string
+    {
+        return 'settings';
+    }
+
+    #[Field(name: 'numberOfParameters')]
+    public function setOfParameters(): int
+    {
+        return 4;
+    }
+}