Skip to content

Commit 884a5fe

Browse files
oprypkhantcoprypkhantc
committed
Allow callable() as field deferring mechanism
1 parent 434b7ea commit 884a5fe

File tree

11 files changed

+269
-17
lines changed

11 files changed

+269
-17
lines changed

‎src/Mappers/CannotMapTypeException.php‎

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use GraphQL\Type\Definition\Type;
1414
use phpDocumentor\Reflection\Type as PhpDocumentorType;
1515
use phpDocumentor\Reflection\Types\Array_;
16+
use phpDocumentor\Reflection\Types\Callable_;
1617
use phpDocumentor\Reflection\Types\Iterable_;
1718
use phpDocumentor\Reflection\Types\Mixed_;
1819
use phpDocumentor\Reflection\Types\Object_;
@@ -124,7 +125,7 @@ public static function extendTypeWithBadTargetedClass(string $className, ExtendT
124125
return new self('For ' . self::extendTypeToString($extendType) . ' annotation declared in class "' . $className . '", the pointed at GraphQL type cannot be extended. You can only target types extending the MutableObjectType (like types created with the @Type annotation).');
125126
}
126127

127-
/** @param Array_|Iterable_|Object_|Mixed_ $type */
128+
/** @param Array_|Iterable_|Object_|Mixed_|Callable_ $type */
128129
public static function createForMissingPhpDoc(PhpDocumentorType $type, ReflectionMethod|ReflectionProperty $reflector, string|null $argumentName = null): self
129130
{
130131
$typeStr = '';
@@ -136,6 +137,8 @@ public static function createForMissingPhpDoc(PhpDocumentorType $type, Reflectio
136137
$typeStr = sprintf('object ("%s")', $type->getFqsen());
137138
} elseif ($type instanceof Mixed_) {
138139
$typeStr = 'mixed';
140+
} elseif ($type instanceof Callable_) {
141+
$typeStr = 'callable';
139142
}
140143
assert($typeStr !== '');
141144
if ($argumentName === null) {
@@ -177,4 +180,19 @@ public static function createForNonNullReturnByTypeMapper(): self
177180
{
178181
return new self('a type mapper returned a GraphQL\Type\Definition\NonNull instance. All instances returned by type mappers should be nullable. It is the role of the NullableTypeMapperAdapter class to make a GraphQL type in a "NonNull". Note: this is an error in the TypeMapper code or in GraphQLite itself. Please check your custom type mappers or open an issue on GitHub if you don\'t have any custom type mapper.');
179182
}
183+
184+
public static function createForUnexpectedCallableParameters(): self
185+
{
186+
return new self('callable() type-hint must not specify any parameters.');
187+
}
188+
189+
public static function createForMissingCallableReturnType(): self
190+
{
191+
return new self('callable() type-hint must specify its return type. For instance: callable(): int');
192+
}
193+
194+
public static function createForCallableAsInput(): self
195+
{
196+
return new self('callable() type-hint can only be used as output type.');
197+
}
180198
}

‎src/Mappers/Parameters/TypeHandler.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
use phpDocumentor\Reflection\Type;
1717
use phpDocumentor\Reflection\TypeResolver as PhpDocumentorTypeResolver;
1818
use phpDocumentor\Reflection\Types\Array_;
19+
use phpDocumentor\Reflection\Types\Callable_;
1920
use phpDocumentor\Reflection\Types\Collection;
2021
use phpDocumentor\Reflection\Types\Compound;
2122
use phpDocumentor\Reflection\Types\Iterable_;
@@ -375,6 +376,7 @@ private function mapType(
375376
$innerType instanceof Array_
376377
|| $innerType instanceof Iterable_
377378
|| $innerType instanceof Mixed_
379+
|| $innerType instanceof Callable_
378380
// Try to match generic phpdoc-provided iterables with non-generic return-type-provided iterables
379381
// Example: (return type `\ArrayObject`, phpdoc `\ArrayObject<string, TestObject>`)
380382
|| ($innerType instanceof Object_

‎src/Mappers/Root/CallableTypeMapper.php‎

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace TheCodingMachine\GraphQLite\Mappers\Root;
6+
7+
use GraphQL\Type\Definition\InputType;
8+
use GraphQL\Type\Definition\NamedType;
9+
use GraphQL\Type\Definition\OutputType;
10+
use GraphQL\Type\Definition\Type as GraphQLType;
11+
use phpDocumentor\Reflection\DocBlock;
12+
use phpDocumentor\Reflection\Type;
13+
use phpDocumentor\Reflection\Types\Callable_;
14+
use ReflectionMethod;
15+
use ReflectionProperty;
16+
use TheCodingMachine\GraphQLite\Mappers\CannotMapTypeException;
17+
18+
/**
19+
* This mapper maps callable types into their return types, so that fields can defer their execution.
20+
*/
21+
class CallableTypeMapper implements RootTypeMapperInterface
22+
{
23+
public function __construct(
24+
private readonly RootTypeMapperInterface $next,
25+
private readonly RootTypeMapperInterface $topRootTypeMapper,
26+
) {
27+
}
28+
29+
public function toGraphQLOutputType(Type $type, OutputType|null $subType, ReflectionMethod|ReflectionProperty $reflector, DocBlock $docBlockObj): OutputType&GraphQLType
30+
{
31+
if (! $type instanceof Callable_) {
32+
return $this->next->toGraphQLOutputType($type, $subType, $reflector, $docBlockObj);
33+
}
34+
35+
if ($type->getParameters()) {
36+
throw CannotMapTypeException::createForUnexpectedCallableParameters();
37+
}
38+
39+
$returnType = $type->getReturnType();
40+
41+
if (! $returnType) {
42+
throw CannotMapTypeException::createForMissingCallableReturnType();
43+
}
44+
45+
return $this->topRootTypeMapper->toGraphQLOutputType($returnType, null, $reflector, $docBlockObj);
46+
}
47+
48+
public function toGraphQLInputType(Type $type, InputType|null $subType, string $argumentName, ReflectionMethod|ReflectionProperty $reflector, DocBlock $docBlockObj): InputType&GraphQLType
49+
{
50+
if (! $type instanceof Callable_) {
51+
return $this->next->toGraphQLInputType($type, $subType, $argumentName, $reflector, $docBlockObj);
52+
}
53+
54+
throw CannotMapTypeException::createForCallableAsInput();
55+
}
56+
57+
public function mapNameToType(string $typeName): NamedType&GraphQLType
58+
{
59+
return $this->next->mapNameToType($typeName);
60+
}
61+
}

‎src/QueryField.php‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace TheCodingMachine\GraphQLite;
66

77
use Closure;
8+
use GraphQL\Deferred;
89
use GraphQL\Error\ClientAware;
910
use GraphQL\Executor\Promise\Adapter\SyncPromise;
1011
use GraphQL\Language\AST\FieldDefinitionNode;
@@ -20,6 +21,8 @@
2021
use TheCodingMachine\GraphQLite\Parameters\ParameterInterface;
2122
use TheCodingMachine\GraphQLite\Parameters\SourceParameter;
2223

24+
use function is_callable;
25+
2326
/**
2427
* A GraphQL field that maps to a PHP method automatically.
2528
*
@@ -92,6 +95,13 @@ public function __construct(
9295

9396
private function resolveWithPromise(mixed $result, ResolverInterface $originalResolver): mixed
9497
{
98+
// Shorthand for deferring field execution. This does two things:
99+
// - removes the dependency on `GraphQL\Deferred` from user land code
100+
// - allows inferring the type from PHPDoc (callable(): Type), unlike Deferred, which is not generic
101+
if (is_callable($result)) {
102+
$result = new Deferred($result);
103+
}
104+
95105
if ($result instanceof SyncPromise) {
96106
return $result->then(fn ($resolvedValue) => $this->resolveWithPromise($resolvedValue, $originalResolver));
97107
}

‎src/SchemaFactory.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
use TheCodingMachine\GraphQLite\Mappers\PorpaginasTypeMapper;
3636
use TheCodingMachine\GraphQLite\Mappers\RecursiveTypeMapper;
3737
use TheCodingMachine\GraphQLite\Mappers\Root\BaseTypeMapper;
38+
use TheCodingMachine\GraphQLite\Mappers\Root\CallableTypeMapper;
3839
use TheCodingMachine\GraphQLite\Mappers\Root\CompoundTypeMapper;
3940
use TheCodingMachine\GraphQLite\Mappers\Root\EnumTypeMapper;
4041
use TheCodingMachine\GraphQLite\Mappers\Root\FinalRootTypeMapper;
@@ -399,6 +400,7 @@ public function createSchema(): Schema
399400
$lastTopRootTypeMapper = new LastDelegatingTypeMapper();
400401
$topRootTypeMapper = new NullableTypeMapperAdapter($lastTopRootTypeMapper);
401402
$topRootTypeMapper = new VoidTypeMapper($topRootTypeMapper);
403+
$topRootTypeMapper = new CallableTypeMapper($topRootTypeMapper, $lastTopRootTypeMapper);
402404

403405
$errorRootTypeMapper = new FinalRootTypeMapper($recursiveTypeMapper);
404406
$rootTypeMapper = new BaseTypeMapper($errorRootTypeMapper, $recursiveTypeMapper, $topRootTypeMapper);

‎tests/AbstractQueryProvider.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
use TheCodingMachine\GraphQLite\Mappers\Parameters\ResolveInfoParameterHandler;
4242
use TheCodingMachine\GraphQLite\Mappers\RecursiveTypeMapper;
4343
use TheCodingMachine\GraphQLite\Mappers\Root\BaseTypeMapper;
44+
use TheCodingMachine\GraphQLite\Mappers\Root\CallableTypeMapper;
4445
use TheCodingMachine\GraphQLite\Mappers\Root\CompoundTypeMapper;
4546
use TheCodingMachine\GraphQLite\Mappers\Root\EnumTypeMapper;
4647
use TheCodingMachine\GraphQLite\Mappers\Root\FinalRootTypeMapper;
@@ -359,6 +360,7 @@ protected function buildRootTypeMapper(): RootTypeMapperInterface
359360
$lastTopRootTypeMapper = new LastDelegatingTypeMapper();
360361
$topRootTypeMapper = new NullableTypeMapperAdapter($lastTopRootTypeMapper);
361362
$topRootTypeMapper = new VoidTypeMapper($topRootTypeMapper);
363+
$topRootTypeMapper = new CallableTypeMapper($topRootTypeMapper, $lastTopRootTypeMapper);
362364

363365
$errorRootTypeMapper = new FinalRootTypeMapper($this->getTypeMapper());
364366
$rootTypeMapper = new BaseTypeMapper(

‎tests/Fixtures/Integration/Models/Blog.php‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,17 @@ public function getPosts(
3636
return $prefetchedPosts[$this->id];
3737
}
3838

39-
/** @param Blog[][] $prefetchedSubBlogs */
40-
#[Field(outputType: '[Blog!]!')]
39+
/**
40+
* @param Blog[][] $prefetchedSubBlogs
41+
*
42+
* @return callable(): Blog[]
43+
*/
44+
#[Field]
4145
public function getSubBlogs(
4246
#[Prefetch('prefetchSubBlogs')]
4347
array $prefetchedSubBlogs,
44-
): Deferred {
45-
return new Deferred(fn () => $prefetchedSubBlogs[$this->id]);
48+
): callable {
49+
return fn () => $prefetchedSubBlogs[$this->id];
4650
}
4751

4852
/**

‎tests/Integration/IntegrationTestCase.php‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
use TheCodingMachine\GraphQLite\Mappers\RecursiveTypeMapper;
4242
use TheCodingMachine\GraphQLite\Mappers\RecursiveTypeMapperInterface;
4343
use TheCodingMachine\GraphQLite\Mappers\Root\BaseTypeMapper;
44+
use TheCodingMachine\GraphQLite\Mappers\Root\CallableTypeMapper;
4445
use TheCodingMachine\GraphQLite\Mappers\Root\CompoundTypeMapper;
4546
use TheCodingMachine\GraphQLite\Mappers\Root\EnumTypeMapper;
4647
use TheCodingMachine\GraphQLite\Mappers\Root\FinalRootTypeMapper;
@@ -296,10 +297,13 @@ public function createContainer(array $overloadedServices = []): ContainerInterf
296297
);
297298
},
298299
RootTypeMapperInterface::class => static function (ContainerInterface $container) {
299-
return new VoidTypeMapper(
300-
new NullableTypeMapperAdapter(
301-
$container->get('topRootTypeMapper')
302-
)
300+
return new CallableTypeMapper(
301+
new VoidTypeMapper(
302+
new NullableTypeMapperAdapter(
303+
$container->get('topRootTypeMapper')
304+
)
305+
),
306+
$container->get('topRootTypeMapper')
303307
);
304308
},
305309
'topRootTypeMapper' => static function () {

‎tests/Mappers/Root/CallableTypeMapperTest.php‎

Lines changed: 130 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
<?php
2+
3+
namespace TheCodingMachine\GraphQLite\Mappers\Root;
4+
5+
use Generator;
6+
use GraphQL\Type\Definition\InputType;
7+
use GraphQL\Type\Definition\NamedType;
8+
use GraphQL\Type\Definition\NonNull;
9+
use GraphQL\Type\Definition\OutputType;
10+
use GraphQL\Type\Definition\StringType;
11+
use GraphQL\Type\Definition\Type as GraphQLType;
12+
use phpDocumentor\Reflection\DocBlock;
13+
use phpDocumentor\Reflection\Type;
14+
use phpDocumentor\Reflection\Types\Array_;
15+
use phpDocumentor\Reflection\Types\Callable_;
16+
use phpDocumentor\Reflection\Types\CallableParameter;
17+
use phpDocumentor\Reflection\Types\Nullable;
18+
use phpDocumentor\Reflection\Types\Object_;
19+
use phpDocumentor\Reflection\Types\String_;
20+
use PHPUnit\Framework\Attributes\CoversClass;
21+
use PHPUnit\Framework\Attributes\DataProvider;
22+
use ReflectionMethod;
23+
use TheCodingMachine\GraphQLite\AbstractQueryProvider;
24+
use TheCodingMachine\GraphQLite\Fixtures\TestObject;
25+
use TheCodingMachine\GraphQLite\Fixtures\TestObject2;
26+
use TheCodingMachine\GraphQLite\Mappers\CannotMapTypeException;
27+
28+
#[CoversClass(CallableTypeMapper::class)]
29+
class CallableTypeMapperTest extends AbstractQueryProvider
30+
{
31+
public function testMapsCallableReturnTypeUsingTopRootMapper(): void
32+
{
33+
$reflection = new ReflectionMethod(__CLASS__, 'testSkipsNonCallables');
34+
$docBlock = new DocBlock();
35+
36+
$returnType = new String_();
37+
38+
$topRootMapper = $this->createMock(RootTypeMapperInterface::class);
39+
$topRootMapper->expects($this->once())
40+
->method('toGraphQLOutputType')
41+
->with($returnType, null, $reflection, $docBlock)
42+
->willReturn(GraphQLType::string());
43+
44+
$mapper = new CallableTypeMapper(
45+
$this->createMock(RootTypeMapperInterface::class),
46+
$topRootMapper,
47+
);
48+
49+
$result = $mapper->toGraphQLOutputType(new Callable_(returnType: $returnType), null, $reflection, $docBlock);
50+
51+
$this->assertSame(GraphQLType::string(), $result);
52+
}
53+
54+
public function testThrowsWhenUsingCallableWithParameters(): void
55+
{
56+
$this->expectExceptionObject(CannotMapTypeException::createForUnexpectedCallableParameters());
57+
58+
$mapper = new CallableTypeMapper(
59+
$this->createMock(RootTypeMapperInterface::class),
60+
$this->createMock(RootTypeMapperInterface::class)
61+
);
62+
63+
$type = new Callable_(
64+
parameters: [
65+
new CallableParameter(new String_())
66+
]
67+
);
68+
69+
$mapper->toGraphQLOutputType($type, null, new ReflectionMethod(__CLASS__, 'testSkipsNonCallables'), new DocBlock());
70+
}
71+
72+
public function testThrowsWhenUsingCallableWithoutReturnType(): void
73+
{
74+
$this->expectExceptionObject(CannotMapTypeException::createForMissingCallableReturnType());
75+
76+
$mapper = new CallableTypeMapper(
77+
$this->createMock(RootTypeMapperInterface::class),
78+
$this->createMock(RootTypeMapperInterface::class)
79+
);
80+
81+
$mapper->toGraphQLOutputType(new Callable_(), null, new ReflectionMethod(__CLASS__, 'testSkipsNonCallables'), new DocBlock());
82+
}
83+
84+
public function testThrowsWhenUsingCallableAsInputType(): void
85+
{
86+
$this->expectExceptionObject(CannotMapTypeException::createForCallableAsInput());
87+
88+
$mapper = new CallableTypeMapper(
89+
$this->createMock(RootTypeMapperInterface::class),
90+
$this->createMock(RootTypeMapperInterface::class)
91+
);
92+
93+
$mapper->toGraphQLInputType(new Callable_(), null, 'arg1', new ReflectionMethod(__CLASS__, 'testSkipsNonCallables'), new DocBlock());
94+
}
95+
96+
#[DataProvider('skipsNonCallablesProvider')]
97+
public function testSkipsNonCallables(callable $createType): void
98+
{
99+
$type = $createType();
100+
$reflection = new ReflectionMethod(__CLASS__, 'testSkipsNonCallables');
101+
$docBlock = new DocBlock();
102+
103+
$next = $this->createMock(RootTypeMapperInterface::class);
104+
$next->expects($this->once())
105+
->method('toGraphQLOutputType')
106+
->with($type, null, $reflection, $docBlock)
107+
->willReturn(GraphQLType::string());
108+
$next->expects($this->once())
109+
->method('toGraphQLInputType')
110+
->with($type, null, 'arg1', $reflection, $docBlock)
111+
->willReturn(GraphQLType::int());
112+
$next->expects($this->once())
113+
->method('mapNameToType')
114+
->with('Name')
115+
->willReturn(GraphQLType::float());
116+
117+
$mapper = new CallableTypeMapper($next, $this->createMock(RootTypeMapperInterface::class));
118+
119+
$this->assertSame(GraphQLType::string(), $mapper->toGraphQLOutputType($type, null, $reflection, $docBlock));
120+
$this->assertSame(GraphQLType::int(), $mapper->toGraphQLInputType($type, null, 'arg1', $reflection, $docBlock));
121+
$this->assertSame(GraphQLType::float(), $mapper->mapNameToType('Name'));
122+
}
123+
124+
public static function skipsNonCallablesProvider(): iterable
125+
{
126+
yield [fn () => new Object_()];
127+
yield [fn () => new Array_()];
128+
yield [fn () => new String_()];
129+
}
130+
}

‎tests/QueryFieldTest.php‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
namespace TheCodingMachine\GraphQLite;
66

77
use GraphQL\Error\Error;
8+
use GraphQL\Executor\Promise\Adapter\SyncPromise;
9+
use GraphQL\Executor\Promise\Adapter\SyncPromiseAdapter;
10+
use GraphQL\Executor\Promise\Promise;
811
use GraphQL\Type\Definition\ResolveInfo;
912
use GraphQL\Type\Definition\Type;
1013
use PHPUnit\Framework\TestCase;
@@ -45,4 +48,21 @@ public function testParametersDescription(): void
4548

4649
$this->assertEquals('Foo argument', $queryField->args[0]->description);
4750
}
51+
52+
public function testWrapsCallableInDeferred(): void
53+
{
54+
$sourceResolver = new ServiceResolver(static fn () => function () {
55+
return 123;
56+
});
57+
$queryField = new QueryField('foo', Type::string(), [], $sourceResolver, $sourceResolver, null, null, []);
58+
59+
$deferred = ($queryField->resolveFn)(null, [], null, $this->createStub(ResolveInfo::class));
60+
61+
$this->assertInstanceOf(SyncPromise::class, $deferred);
62+
63+
$syncPromiseAdapter = new SyncPromiseAdapter();
64+
$syncPromiseAdapter->wait(new Promise($deferred, $syncPromiseAdapter));
65+
66+
$this->assertSame(123, $deferred->result);
67+
}
4868
}

0 commit comments

Comments
 (0)