Improving code coverage

Author: moufmouf

docs/annotations_reference.md

@@ -123,7 +123,7 @@ query / mutation / field (according to the `@Logged` and `@Right` annotations).
 
 Attribute      | Compulsory | Type | Definition
 ---------------|------------|------|--------
-*default*      | *yes*       | mixed | The value to return if the user is not authorized.
+value          | *yes*       | mixed | The value to return if the user is not authorized.
 
 ## @HideIfUnauthorized annotation
 

docs/authentication_authorization.md

@@ -101,7 +101,7 @@ class UserController
     #[Query]
     #[Logged]
     #[Right("CAN_VIEW_USER_LIST")]
-    #[FailWith(null)]
+    #[FailWith(value: null)]
     public function users(int $limit, int $offset): array
     {
         // ...

src/Annotations/FailWith.php

@@ -8,6 +8,7 @@
 use BadMethodCallException;
 
 use function array_key_exists;
+use function is_array;
 
 /**
  * @Annotation
@@ -37,7 +38,7 @@ public function __construct($values = [], $value = '__fail__with__magic__key__')
     {
         if ($value !== '__fail__with__magic__key__') {
             $this->value = $value;
-        } elseif (array_key_exists('value', $values)) {
+        } elseif (is_array($values) && array_key_exists('value', $values)) {
             $this->value = $values['value'];
         } else {
             throw new BadMethodCallException('The @FailWith annotation must be passed a defaultValue. For instance: "@FailWith(null)"');

tests/Annotations/DecorateTest.php

@@ -4,6 +4,7 @@
 
 use BadMethodCallException;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 
 class DecorateTest extends TestCase
 {
@@ -14,4 +15,18 @@ public function testException(): void
         $this->expectExceptionMessage('The @Decorate annotation must be passed an input type. For instance: "@Decorate("MyInputType")"');
         new Decorate([]);
     }
+
+    /**
+     * @requires PHP >= 8.0
+     */
+    public function testPhp8Annotation(): void
+    {
+        $method = new ReflectionMethod(__CLASS__, 'method1');
+        $attribute = $method->getAttributes()[0]->newInstance();
+        $this->assertSame('foobar', $attribute->getInputTypeName());
+    }
+
+    #[Decorate("foobar")]
+    public function method1(): void {
+    }
 }

tests/Annotations/FailWithTest.php

@@ -4,6 +4,7 @@
 
 use BadMethodCallException;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 
 class FailWithTest extends TestCase
 {
@@ -14,4 +15,19 @@ public function testException(): void
         $this->expectExceptionMessage('The @FailWith annotation must be passed a defaultValue. For instance: "@FailWith(null)"');
         new FailWith([]);
     }
+
+    /**
+     * @requires PHP >= 8.0
+     */
+    public function testPhp8Annotation(): void
+    {
+        $method = new ReflectionMethod(__CLASS__, 'method1');
+        $failWith = $method->getAttributes()[0]->newInstance();
+        $this->assertSame(null, $failWith->getValue());
+    }
+
+    #[FailWith(value: null)]
+    public function method1(): void {
+    }
+
 }

tests/Annotations/SecurityTest.php

@@ -4,6 +4,8 @@
 
 use BadMethodCallException;
 use PHPUnit\Framework\TestCase;
+use stdClass;
+use TypeError;
 
 class SecurityTest extends TestCase
 {
@@ -21,4 +23,11 @@ public function testIncompatibleParams(): void
         $this->expectExceptionMessage('A @Security annotation that has "failWith" attribute set cannot have a message or a statusCode attribute.');
         new Security(['expression'=>'foo', 'failWith'=>null, 'statusCode'=>500]);
     }
+
+    public function testBadParams2(): void
+    {
+        $this->expectException(TypeError::class);
+        $this->expectExceptionMessage('"TheCodingMachine\GraphQLite\Annotations\Security::__construct": Argument $data is expected to be a string or array, got "object".');
+        new Security(new stdClass());
+    }
 }

tests/Annotations/UseInputTypeTest.php

@@ -4,6 +4,7 @@
 
 use BadMethodCallException;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 
 class UseInputTypeTest extends TestCase
 {
@@ -21,4 +22,13 @@ public function testException2(): void
         $this->expectExceptionMessage('The @UseInputType annotation must be passed a target and an input type. For instance: "@UseInputType(for="$input", inputType="MyInputType")" in PHP 7+ or #[UseInputType("MyInputType")] in PHP 8+');
         (new UseInputType(['inputType' => 'foo']))->getTarget();
     }
+
+    /**
+     * @requires PHP >= 8.0
+     */
+    public function testPhp8Annotation(): void
+    {
+        $attribute = new UseInputType('foo');
+        $this->assertSame('foo', $attribute->getInputType());
+    }
 }