Skip to content

Conversation

oojacoboo
Copy link
Collaborator

Fixes #697

@oojacoboo oojacoboo merged commit 7a75a73 into thecodingmachine:master Dec 18, 2024
9 checks passed
@oojacoboo oojacoboo deleted the issue-697 branch December 18, 2024 07:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (53f9d49) to head (9710100).
Report is 106 commits behind head on master.

Files with missing lines Patch % Lines
src/Mappers/Proxys/MutableAdapterTrait.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #721      +/-   ##
============================================
- Coverage     95.72%   95.21%   -0.52%     
- Complexity     1773     1831      +58     
============================================
  Files           154      174      +20     
  Lines          4586     4954     +368     
============================================
+ Hits           4390     4717     +327     
- Misses          196      237      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cvergne
Copy link
Contributor

cvergne commented Jun 6, 2025

@oojacoboo Hi, is it possible to do a minor release to have (at least) this bug fix please (but #722 would be great too, to have 8.4 support) ? 😬 Thanks !

@oojacoboo
Copy link
Collaborator Author

@cvergne https://github.com/thecodingmachine/graphqlite/releases/tag/v8.0.1

@cvergne
Copy link
Contributor

cvergne commented Jun 6, 2025

@oojacoboo thanks ! (but the tag is still 8.0.1, not 8.1.0 as you said in the description of the release 😅)

@oojacoboo
Copy link
Collaborator Author

@cvergne thanks for catching that. I originally started the release with 8.0.1, but decided to update for 8.1.0 b/c of PHP 8.4 support. Tag fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should MutableObjectTypeAdapter be setting description?

3 participants