Skip to content

Commit 3709700

Browse files
author
David Maechler
committed
fixing delimiter issuer with simple function case and add a unit test for this case too.
1 parent 333d3e4 commit 3709700

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/SQLParser/Node/SimpleFunction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public function toSql(array $parameters = array(), Connection $dbConnection = nu
172172
if (!empty($this->baseExpression)) {
173173
$sql .= $this->baseExpression.'(';
174174
}
175-
$sql .= NodeFactory::toSql($this->subTree, $dbConnection, $parameters, ' ', false, $indent, $conditionsMode);
175+
$sql .= NodeFactory::toSql($this->subTree, $dbConnection, $parameters, ',', false, $indent, $conditionsMode);
176176
if (!empty($this->baseExpression)) {
177177
$sql .= ')';
178178
}

tests/Mouf/Database/MagicQueryTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ public function testStandardSelect()
1212
{
1313
$magicQuery = new MagicQuery();
1414

15+
$sql = "SELECT DATE_FORMAT(CURDATE(), '%d/%m/%Y') AS current_date FROM users WHERE name LIKE :name";
16+
$this->assertEquals("SELECT DATE_FORMAT(CURDATE(), '%d/%m/%Y') AS current_date FROM users WHERE name LIKE 'foo'", self::simplifySql($magicQuery->build($sql, ['name' => 'foo'])));
17+
1518
$sql = 'SELECT YEAR(CURDATE()) AS current_year FROM users WHERE name LIKE :name';
1619
$this->assertEquals("SELECT YEAR(CURDATE()) AS current_year FROM users WHERE name LIKE 'foo'", self::simplifySql($magicQuery->build($sql, ['name' => 'foo'])));
1720

0 commit comments

Comments
 (0)