Skip to content

Commit 668062b

Browse files
committed
Fixed issue on GroupBy clause
1 parent f7428c2 commit 668062b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/SQLParser/Query/Select.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ public function toSql(array $parameters = array(), Connection $dbConnection = nu
350350
}
351351

352352
if (!empty($this->group)) {
353-
$groupBy = NodeFactory::toSql($this->group, $dbConnection, $parameters, ' ', false, $indent + 2, $conditionsMode);
353+
$groupBy = NodeFactory::toSql($this->group, $dbConnection, $parameters, ',', false, $indent + 2, $conditionsMode);
354354
if ($groupBy) {
355355
$sql .= "\nGROUP BY ".$groupBy;
356356
}

tests/Mouf/Database/MagicQueryTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,9 @@ public function testStandardSelect()
104104

105105
$sql = 'SELECT * FROM users WHERE status IN :statuses!';
106106
$this->assertEquals('SELECT * FROM users WHERE FALSE', self::simplifySql($magicQuery->build($sql, ['statuses' => []])));
107+
108+
$sql = 'SELECT * FROM users GROUP BY id, login';
109+
$this->assertEquals('SELECT * FROM users GROUP BY id, login', self::simplifySql($magicQuery->build($sql)));
107110
}
108111

109112
/**

0 commit comments

Comments
 (0)