Improving unit tests, moving setter into constructor

Author: moufmouf

src/Mouf/Database/MagicQuery.php

@@ -153,8 +153,7 @@ private function magicJoin(NodeInterface $select) {
      */
     private function magicJoinOnOneQuery(MagicJoinSelect $magicJoinSelect) {
         $tableSearchNodeTraverser = new NodeTraverser();
-        $detectTableVisitor = new DetectTablesVisitor();
-        $detectTableVisitor->setDefaultTable($magicJoinSelect->getMainTable());
+        $detectTableVisitor = new DetectTablesVisitor($magicJoinSelect->getMainTable());
         $tableSearchNodeTraverser->addVisitor($detectTableVisitor);
 
         $select = $magicJoinSelect->getSelect();

src/SQLParser/Node/Traverser/DetectTablesVisitor.php

@@ -29,11 +29,9 @@ public function resetVisitor() {
     }
 
     /**
-     * Sets the default table that will be used if no table is specified.
-     *
-     * @param string $defaultTable
+     * @param string $defaultTable Sets the default table that will be used if no table is specified in a colref.
      */
-    public function setDefaultTable($defaultTable)
+    public function __construct($defaultTable)
     {
         $this->defaultTable = $defaultTable;
     }

tests/SQLParser/Node/Traverser/DetectTableVisitorTest.php

@@ -8,7 +8,7 @@ class DetectTableVisitorTest extends \PHPUnit_Framework_TestCase
 {
     public function testStandardSelect()
     {
-        $visitor = new DetectTablesVisitor();
+        $visitor = new DetectTablesVisitor('users');
         $nodeTraverser = new NodeTraverser();
         $nodeTraverser->addVisitor($visitor);
 
@@ -38,7 +38,7 @@ public function testStandardSelect()
 
     public function testWrappedSelect()
     {
-        $visitor = new DetectTablesVisitor();
+        $visitor = new DetectTablesVisitor('users');
         $nodeTraverser = new NodeTraverser();
         $nodeTraverser->addVisitor($visitor);
 
@@ -59,8 +59,7 @@ public function testWrappedSelect()
 
     public function testMissingRefTable()
     {
-        $visitor = new DetectTablesVisitor();
-        $visitor->setDefaultTable('yop');
+        $visitor = new DetectTablesVisitor('yop');
         $nodeTraverser = new NodeTraverser();
         $nodeTraverser->addVisitor($visitor);
 
@@ -71,6 +70,6 @@ public function testMissingRefTable()
         $select = StatementFactory::toObject($parsed);
         $nodeTraverser->walk($select);
 
-        // TODO check that tata is scoped in yop
+        $this->assertEquals("yop", $select->getWhere()->getLeftOperand()->getTable());
     }
 }