Switching to Symfony/finder for file scanning

Author: moufmouf

generator/composer.json

@@ -12,7 +12,8 @@
     "phpoffice/phpspreadsheet": "^1.4",
     "ext-json": "^1.5",
     "symfony/console": "^4.1.4",
-    "symfony/process": "^4.1"
+    "symfony/process": "^4.1",
+    "symfony/finder": "^4.1"
   },
   "require-dev": {
     "phpunit/phpunit": "^7",

generator/composer.lock

@@ -27,7 +27,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $excludedModules = [
             'snmp'
         ];
-        $scanner = new Scanner(__DIR__ . '/../doc/doc-en/en/reference/*', $excludedModules);
+        $scanner = new Scanner(__DIR__ . '/../doc/doc-en/en/reference/', $excludedModules);
 
         [
             'functions' => $functions,

generator/src/GenerateCommand.php

@@ -3,7 +3,9 @@
 namespace Safe;
 
 use function array_merge;
+use function iterator_to_array;
 use Safe\PhpStanFunctions\PhpStanFunctionMapReader;
+use Symfony\Component\Finder\Finder;
 
 class Scanner
 {
@@ -32,13 +34,10 @@ public function __construct(string $_path, array $excludedModules)
      */
     public function getPaths(): array
     {
-        $incompletePaths = glob($this->path, GLOB_ONLYDIR);
+        $finder = new Finder();
+        $finder->in($this->path.'*/functions/')->name('*.xml')->sortByName();
 
-        $paths = [];
-        foreach ($incompletePaths as $incompletePath) {
-            $paths = array_merge($paths, glob($incompletePath.'/functions/*.xml'));
-        }
-        return $paths;
+        return iterator_to_array($finder);
     }
 
     private $ignoredFunctions;