Merge pull request #180 from Kharhamel/fix/datetimeImmutable

fixed an issue with datetimeimmutable comparaison

Author: Kharhamel

.gitattributes

@@ -4,5 +4,5 @@
 /CONTRIBUTING.md export-ignore
 /phpcs.xml.dist export-ignore
 /phpstan.neon export-ignore
-/benchmark export-ignore
+/performance export-ignore
 /generator export-ignore

generator/tests/DateTimeImmutableTest.php

@@ -142,4 +142,15 @@ public function testSerialize()
         $this->assertEquals($safeDatetime->getTimestamp(), $newDatetime->getTimestamp());
         $this->assertEquals($safeDatetime->getTimezone(), $newDatetime->getTimezone());
     }
+    
+    public function testComparaison(): void
+    {
+        $safeDateTime = new \Safe\DateTimeImmutable();
+        $phpDateTime = new \DateTimeImmutable();
+        $timeLimit = \DateInterval::createFromDateString('2 hours');
+
+        $a = $safeDateTime->modify('+3 hours') < $safeDateTime->add($timeLimit);
+        $b = $phpDateTime->modify('+3 hours') < $phpDateTime->add($timeLimit);
+        $this->assertEquals($b, $a);
+    }
 }

lib/DateTimeImmutable.php

@@ -28,14 +28,14 @@ class DateTimeImmutable extends \DateTimeImmutable
      */
     public function __construct($time = 'now', $timezone = null)
     {
-        parent::__construct();
+        parent::__construct($time, $timezone);
         $this->innerDateTime = new parent($time, $timezone);
     }
 
     //switch from regular datetime to safe version
     private static function createFromRegular(\DateTimeImmutable $datetime): self
     {
-        $safeDatetime = new self();
+        $safeDatetime = new self($datetime->format('Y-m-d H:i:s'), $datetime->getTimezone()); //we need to also update the wrapper to not break the operators '<' and '>'
         $safeDatetime->innerDateTime = $datetime;
         return $safeDatetime;
     }