Fix: Drop support for unsupported versions of rector/rector

Author: localheinz

.github/workflows/continuous-integration.yml

@@ -89,13 +89,10 @@ jobs:
             echo "Generated files are different from commited files. Please run './safe.php generate' command and commit the results."
             exit 1;
           fi
-      - name: "Check if refactoring can be done with rector/rector:~0.5.0"
-        run: "composer install && composer rector && composer test"
-        working-directory: "generator/tests/rector/0.5"
 
-      - name: "Check if refactoring can be done with rector/rector:~0.6.0"
+      - name: "Check if refactoring can be done with rector/rector:~0.7.0"
         run: "composer install && composer rector && composer test"
-        working-directory: "generator/tests/rector/0.6"
+        working-directory: "generator/tests/rector/0.7"
 
       - name: "Archive code coverage results"
         uses: "actions/upload-artifact@v1"

.gitignore

@@ -4,6 +4,5 @@
 /generator/doc/entities/generated.ent
 /composer.lock
 vendor/
-/generator/tests/rector/0.5/composer.lock
-/generator/tests/rector/0.6/composer.lock
+/generator/tests/rector/0.7/composer.lock
 .phpunit.result.cache

README.md

@@ -112,18 +112,22 @@ find these functions but changing the namespace of the functions one function at
 Fortunately, Safe comes bundled with a "Rector" configuration file. [Rector](https://github.com/rectorphp/rector) is a command-line
 tool that performs instant refactoring of your application.
 
-First, you need to install Rector:
+Run
 
 ```bash
-$ composer require --dev rector/rector ^0.6
+$ composer require --dev rector/rector:^0.7
 ```
 
-Now, you simply need to run Rector with this command:
+to install `rector/rector`.
+
+Run
 
 ```bash
-vendor/bin/rector process src/ --config vendor/thecodingmachine/safe/rector-migrate-0.6.yml
+vendor/bin/rector process src/ --config vendor/thecodingmachine/safe/rector-migrate-0.7.yml
 ```
 
+to run `rector/rector`.
+
 *Note:* do not forget to replace "src/" with the path to your source directory.
 
 **Important:** the refactoring only performs a "dumb" replacement of functions. It will not modify the way

generator/src/FileCreator.php

@@ -81,40 +81,13 @@ public function generateFunctionsList(array $functions, string $path): void
         fclose($stream);
     }
 
-    /**
-     * @deprecated Official support for rector/rector:~0.5 is not advertised anymore.
-     *
-     * This function generate a rector yml file containing a replacer for all functions
-     *
-     * @param Method[] $functions
-     * @param string $path
-     */
-    public function generateRectorFile(array $functions, string $path): void
-    {
-        $functionNames = $this->getFunctionsNameList($functions);
-        $stream = fopen($path, 'w');
-        if ($stream === false) {
-            throw new \RuntimeException('Unable to write to '.$path);
-        }
-        fwrite($stream, "# This rector file is replacing all core PHP functions with the equivalent \"safe\" functions
-# It is targetting Rector 0.5.x versions.
-# If you are using Rector 0.4, please upgrade your Rector version
-services:
-  Rector\Renaming\Rector\Function_\RenameFunctionRector:
-");
-        foreach ($functionNames as $functionName) {
-            fwrite($stream, '    '.$functionName.": 'Safe\\".$functionName."'\n");
-        }
-        fclose($stream);
-    }
-
     /**
      * Generates a configuration file for replacing all functions when using rector/rector:~0.6.
      *
      * @param Method[] $functions
      * @param string $path
      */
-    public function generateRectorFileForZeroPointSix(array $functions, string $path): void
+    public function generateRectorFileForZeroPointSeven(array $functions, string $path): void
     {
         $functionNames = $this->getFunctionsNameList($functions);
 
@@ -125,7 +98,7 @@ public function generateRectorFileForZeroPointSix(array $functions, string $path
         }
 
         $header = <<<'TXT'
-# This file configures rector/rector:~0.6.0 to replace all PHP functions with their equivalent "safe" functions
+# This file configures rector/rector:~0.7.0 to replace all PHP functions with their equivalent "safe" functions
 
 services:
   Rector\Renaming\Rector\Function_\RenameFunctionRector:

generator/src/GenerateCommand.php

@@ -37,8 +37,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $fileCreator = new FileCreator();
         $fileCreator->generatePhpFile($functions, __DIR__ . '/../../generated/');
         $fileCreator->generateFunctionsList($functions, __DIR__ . '/../../generated/functionsList.php');
-        $fileCreator->generateRectorFile($functions, __DIR__ . '/../../rector-migrate.yml');
-        $fileCreator->generateRectorFileForZeroPointSix($functions, __DIR__ . '/../../rector-migrate-0.6.yml');
+        $fileCreator->generateRectorFileForZeroPointSeven($functions, __DIR__ . '/../../rector-migrate-0.7.yml');
 
 
         $modules = [];

generator/tests/rector/0.5/composer.json

@@ -6,13 +6,13 @@
   },
   "require": {
     "php": "^7.2",
-    "rector/rector": "^0.6.7"
+    "rector/rector": "^0.7.6"
   },
   "require-dev": {
     "phpunit/phpunit": "^7"
   },
   "scripts": {
-    "rector": "rector process src/ --config ../../../../rector-migrate-0.6.yml",
+    "rector": "rector process src/ --config ../../../../rector-migrate-0.7.yml",
     "test": "phpunit"
   }
 }