@@ -2031,6 +2031,10 @@ public function testJsonFormat(): void
2031
2031
*/
2032
2032
public function testJsonCollection (): void
2033
2033
{
2034
+ // This test tries to perform a SELECT DISTINCT on a JSON column (which is represented as a CLOB column in Oracle)
2035
+ // DISTINCT statements cannot be applied on CLOB columns. As a result, JSON columns are not supported in Oracle + TDBM 5 for now.
2036
+ $ this ->skipOracle ();
2037
+
2034
2038
$ artists = new ArtistDao ($ this ->tdbmService );
2035
2039
$ pinkFloyd = $ artists ->getById (1 );
2036
2040
$ animals = $ pinkFloyd ->getAlbums ()[0 ];
@@ -2054,6 +2058,10 @@ public function testJsonCollection(): void
2054
2058
2055
2059
public function testFloydHasNoParent (): void
2056
2060
{
2061
+ // This test tries to perform a SELECT DISTINCT on a JSON column (which is represented as a CLOB column in Oracle)
2062
+ // DISTINCT statements cannot be applied on CLOB columns. As a result, JSON columns are not supported in Oracle + TDBM 5 for now.
2063
+ $ this ->skipOracle ();
2064
+
2057
2065
$ artists = new ArtistDao ($ this ->tdbmService );
2058
2066
$ pinkFloyd = $ artists ->getById (1 );
2059
2067
$ parents = $ pinkFloyd ->getParents ();
@@ -2063,6 +2071,10 @@ public function testFloydHasNoParent(): void
2063
2071
2064
2072
public function testFloydHasOneChild (): void
2065
2073
{
2074
+ // This test tries to perform a SELECT DISTINCT on a JSON column (which is represented as a CLOB column in Oracle)
2075
+ // DISTINCT statements cannot be applied on CLOB columns. As a result, JSON columns are not supported in Oracle + TDBM 5 for now.
2076
+ $ this ->skipOracle ();
2077
+
2066
2078
$ artists = new ArtistDao ($ this ->tdbmService );
2067
2079
$ pinkFloyd = $ artists ->getById (1 );
2068
2080
$ children = $ pinkFloyd ->getChildrenByArtistsRelations ();
@@ -2076,11 +2088,6 @@ public function testFloydHasOneChild(): void
2076
2088
*/
2077
2089
public function testAddInterfaceAnnotation (): void
2078
2090
{
2079
- if (!$ this ->tdbmService ->getConnection ()->getDatabasePlatform () instanceof MySqlPlatform) {
2080
- // See https://github.com/doctrine/dbal/pull/3512
2081
- $ this ->markTestSkipped ('Only MySQL supports table level comments ' );
2082
- }
2083
-
2084
2091
$ refClass = new ReflectionClass (UserBaseBean::class);
2085
2092
$ this ->assertTrue ($ refClass ->implementsInterface (TestUserInterface::class));
2086
2093
}
@@ -2090,11 +2097,6 @@ public function testAddInterfaceAnnotation(): void
2090
2097
*/
2091
2098
public function testAddInterfaceOnDaoAnnotation (): void
2092
2099
{
2093
- if (!$ this ->tdbmService ->getConnection ()->getDatabasePlatform () instanceof MySqlPlatform) {
2094
- // See https://github.com/doctrine/dbal/pull/3512
2095
- $ this ->markTestSkipped ('Only MySQL supports table level comments ' );
2096
- }
2097
-
2098
2100
$ refClass = new ReflectionClass (UserBaseDao::class);
2099
2101
$ this ->assertTrue ($ refClass ->implementsInterface (TestUserDaoInterface::class));
2100
2102
}
@@ -2104,11 +2106,6 @@ public function testAddInterfaceOnDaoAnnotation(): void
2104
2106
*/
2105
2107
public function testTrait (): void
2106
2108
{
2107
- if (!$ this ->tdbmService ->getConnection ()->getDatabasePlatform () instanceof MySqlPlatform) {
2108
- // See https://github.com/doctrine/dbal/pull/3512
2109
- $ this ->markTestSkipped ('Only MySQL supports table level comments ' );
2110
- }
2111
-
2112
2109
$ userDao = new UserDao ($ this ->tdbmService );
2113
2110
$ userBean = $ userDao ->getById (1 );
2114
2111
@@ -2189,6 +2186,8 @@ public function testLazyLoad(): void
2189
2186
*/
2190
2187
public function testOneToOneInverseRelationGetter (): void
2191
2188
{
2189
+ $ this ->skipOracle ();
2190
+
2192
2191
$ objectBaseDao = new BaseObjectDao ($ this ->tdbmService );
2193
2192
$ objectInheritedDao = new InheritedObjectDao ($ this ->tdbmService );
2194
2193
$ objectBase = new BaseObjectBean ('label ' );
0 commit comments