Improving code coverage

Author: moufmouf

tests/QueryFactory/FindObjectsFromRawSqlQueryFactoryTest.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace TheCodingMachine\TDBM\QueryFactory;
+
+use Doctrine\DBAL\Schema\Schema;
+use PHPUnit\Framework\TestCase;
+use TheCodingMachine\TDBM\TDBMAbstractServiceTest;
+use TheCodingMachine\TDBM\TDBMException;
+
+class FindObjectsFromRawSqlQueryFactoryTest extends TDBMAbstractServiceTest
+{
+
+    public function testGetSubQueryColumnDescriptors()
+    {
+        $queryFactory = new FindObjectsFromRawSqlQueryFactory($this->tdbmService, $this->createMock(Schema::class), 'foo', 'bar');
+        $this->expectException(TDBMException::class);
+        $queryFactory->getSubQueryColumnDescriptors();
+    }
+
+    public function testGetMagicSqlSubQuery()
+    {
+        $queryFactory = new FindObjectsFromRawSqlQueryFactory($this->tdbmService, $this->createMock(Schema::class), 'foo', 'bar');
+        $this->expectException(TDBMException::class);
+        $queryFactory->getMagicSqlSubQuery();
+
+    }
+}

tests/TDBMDaoGeneratorTest.php

@@ -2189,7 +2189,7 @@ public function testSQLCountWithArray(): void
     /**
      * @depends testDaoGeneration
      */
-    public function testSubQueryWithFind()
+    public function testSubQueryWithFind(): void
     {
         $userDao = new TestUserDao($this->tdbmService);
         $articleDao = new TestArticleSubQueryDao($this->tdbmService, $userDao);
@@ -2204,4 +2204,13 @@ public function testSubQueryWithFind()
         $this->assertCount(1, $results);
         $this->assertSame('Foo', $results[0]->getContent());
     }
+
+    public function testSubQueryExceptionOnPrimaryKeysWithMultipleColumns(): void
+    {
+        $stateDao = new StateDao($this->tdbmService);
+        $states = $stateDao->findAll();
+        $this->expectException(TDBMException::class);
+        $this->expectExceptionMessage('You cannot use in a sub-query a table that has a primary key on more that 1 column.');
+        $states->_getSubQuery();
+    }
 }