Fixing tests to only test @readonly with MySQL

Author: moufmouf

tests/TDBMAbstractServiceTest.php

@@ -43,6 +43,7 @@
 use TheCodingMachine\TDBM\Utils\Annotation\AddInterface;
 use TheCodingMachine\TDBM\Utils\DefaultNamingStrategy;
 use TheCodingMachine\TDBM\Utils\PathFinder\PathFinder;
+use function stripos;
 
 abstract class TDBMAbstractServiceTest extends TestCase
 {
@@ -416,7 +417,7 @@ private static function initSchema(Connection $connection): void
         }
 
         // Let's generate computed columns
-        if ($connection->getDatabasePlatform() instanceof MySqlPlatform) {
+        if ($connection->getDatabasePlatform() instanceof MySqlPlatform && !self::isMariaDb($connection)) {
             $connection->exec('CREATE TABLE `players` (
                `id` INT UNSIGNED AUTO_INCREMENT NOT NULL,
                `player_and_games` JSON NOT NULL,
@@ -768,4 +769,13 @@ protected static function delete(Connection $connection, string $tableName, arra
         }
         $connection->delete($connection->quoteIdentifier($tableName), $quotedData);
     }
+
+    protected static function isMariaDb(Connection $connection): bool
+    {
+        if (!$connection->getDatabasePlatform() instanceof MySqlPlatform) {
+            return false;
+        }
+        $version = $connection->fetchColumn('SELECT VERSION()');
+        return stripos($version, 'maria') !== false;
+    }
 }

tests/TDBMDaoGeneratorTest.php

@@ -2282,6 +2282,10 @@ public function testFindFromRawSQLOnInheritance(): void
 
     public function testGeneratedColumnsAreNotPartOfTheConstructor(): void
     {
+        if ($this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform && !self::isMariaDb($this->tdbmService->getConnection())) {
+            $this->markTestSkipped('ReadOnly column is only tested with MySQL');
+        }
+
         $dao = new PlayerDao($this->tdbmService);
 
         $player = new PlayerBean([
@@ -2314,6 +2318,10 @@ public function testGeneratedColumnsAreNotPartOfTheConstructor(): void
 
     public function testCanReadVirtualColumn(): void
     {
+        if ($this->tdbmService->getConnection()->getDatabasePlatform() instanceof MySqlPlatform && !self::isMariaDb($this->tdbmService->getConnection())) {
+            $this->markTestSkipped('ReadOnly column is only tested with MySQL');
+        }
+
         $dao = new PlayerDao($this->tdbmService);
 
         $player = $dao->getById(1);