⚡ Avoid systematic count query (#285)

* ⚡ Avoid systematic count query

* fix CI

* Fix PHPStan

* fix CI again

Author: nguyenk

src/EmptyResultIterator.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace TheCodingMachine\TDBM;
+
+class EmptyResultIterator extends ResultIterator
+{
+}

src/PageIterator.php

@@ -121,7 +121,7 @@ public static function createEmpyIterator(ResultIterator $parentResult): self
     public function getIterator(): \Traversable
     {
         if ($this->innerResultIterator === null) {
-            if ($this->parentResult->count() === 0) {
+            if ($this->parentResult instanceof EmptyResultIterator) {
                 $this->innerResultIterator = new EmptyInnerResultIterator();
             } elseif ($this->mode === TDBMService::MODE_CURSOR) {
                 $this->innerResultIterator = InnerResultIterator::createInnerResultIterator($this->magicSql, $this->parameters, $this->limit, $this->offset, $this->columnDescriptors, $this->objectStorage, $this->className, $this->tdbmService, $this->magicQuery, $this->logger);

tests/AbstractTDBMObjectTest.php

@@ -44,7 +44,7 @@ public function testEmptyResultIterator()
 
     public function testEmptyPageIterator()
     {
-        $a = ResultIterator::createEmpyIterator();
+        $a = EmptyResultIterator::createEmpyIterator();
         $b = $a->take(0, 10);
         foreach ($b as $empty) {
             throw new \LogicException("Not supposed to iterate on an empty page iterator.");