Improving test performance

Improving tests performance by using cache.
In the process, I fixed a SQL subquery cache related bug.

Author: moufmouf

src/QueryFactory/FindObjectsQueryFactory.php

@@ -37,7 +37,8 @@ protected function compute(): void
             [
                 $this->magicSql,
                 $this->magicSqlCount,
-                $this->columnDescList
+                $this->columnDescList,
+                $this->magicSqlSubQuery
             ] = $this->cache->fetch($key);
             return;
         }
@@ -79,6 +80,7 @@ protected function compute(): void
             $this->magicSql,
             $this->magicSqlCount,
             $this->columnDescList,
+            $this->magicSqlSubQuery
         ]);
     }
 }

tests/TDBMAbstractServiceTest.php

@@ -70,12 +70,14 @@ abstract class TDBMAbstractServiceTest extends TestCase
     /**
      * @var ArrayCache
      */
-    private $cache;
+    private static $cache;
 
     public static function setUpBeforeClass(): void
     {
         self::resetConnection();
 
+        self::$cache = new ArrayCache();
+
         $dbConnection = ConnectionFactory::resetDatabase(
             $GLOBALS['db_driver'],
             $GLOBALS['db_host'] ?? null,
@@ -134,10 +136,7 @@ protected function getDummyGeneratorListener() : DummyGeneratorListener
 
     protected function getCache(): ArrayCache
     {
-        if ($this->cache === null) {
-            $this->cache = new ArrayCache();
-        }
-        return $this->cache;
+        return self::$cache;
     }
 
     protected function getConfiguration() : ConfigurationInterface