fix playlist import and notification queue system

Author: theweavrs

BreadPlayer.Views.UWP/Common/NotificationManager.cs

@@ -1,5 +1,6 @@
 using BreadPlayer.Core.Common;
 using BreadPlayer.Core.Models;
+using BreadPlayer.Services;
 using System;
 using System.Collections;
 using System.Collections.Generic;
@@ -15,7 +16,7 @@ namespace BreadPlayer.NotificationManager
 {
     public class BreadNotificationManager : ObservableObject, INotificationManager
     {
-        private Queue<string> NotificationQueue => new Queue<string>();
+        private Queue<string> NotificationQueue => GSingleton<Queue<string>>.Instance.Singleton;
         private ICommand _closeCommand;
         private DispatcherTimer _hideTimer;
         private string _status = string.Empty;
@@ -104,14 +105,14 @@ public void SendUpcomingSongNotification(Mediafile mediaFile)
             }
         }
 
-        private void HideTimer_Tick(object sender, object e)
+        private async void HideTimer_Tick(object sender, object e)
         {
             Status = string.Empty;
             Show = false;
             _hideTimer?.Stop();
             if (NotificationQueue.Count > 0)
             {
-                ShowMessageAsync(NotificationQueue.Dequeue()).Wait();
+               await ShowMessageAsync(NotificationQueue.Dequeue()).ConfigureAwait(false);
             }
         }
     }

BreadPlayer.Views.UWP/Helpers/PlaylistHelper.cs

@@ -13,6 +13,7 @@
 using Windows.Storage.Search;
 using BreadPlayer.Common;
 using BreadPlayer.ViewModels;
+using BreadPlayer.Core;
 
 namespace BreadPlayer.Helpers
 {
@@ -52,19 +53,30 @@ await BreadDispatcher.InvokeAsync(async () =>
         {
             var folderPaths = songPaths.GroupBy(t => Path.GetDirectoryName(t));
             Dictionary<string, (List<string> songs, StorageFolder folder)> folders = new Dictionary<string, (List<string> songs, StorageFolder folder)>();
+
             foreach (var folderPath in folderPaths)
             {
-                var folder = await StorageFolder.GetFolderFromPathAsync(folderPath.Key);
-                var token = StorageApplicationPermissions.FutureAccessList.Add(folder);
-                folders.Add(token, (folderPath.ToList(), folder));
+                try
+                {
+                    var folder = await StorageFolder.GetFolderFromPathAsync(folderPath.Key);
+                    var token = StorageApplicationPermissions.FutureAccessList.Add(folder);
+                    folders.Add(token, (folderPath.ToList(), folder));
+                }
+                catch (UnauthorizedAccessException)
+                {
+                    await SharedLogic.Instance.NotificationManager.ShowMessageAsync(string.Format("We cannot import songs due to access problems. Please import {0} to Bread Player library.", folderPath.Key), 5);
+                }
             }
+            
             return folders;
         }
         public static async Task<IEnumerable<Mediafile>> GetSongsInAllFoldersAsync(List<string> songPaths)
         {
             List<Mediafile> songsList = new List<Mediafile>();
             foreach (var folder in await GetFoldersFromSongsAsync(songPaths).ConfigureAwait(false))
             {
+                if (folder.Key == null)
+                    break;
                 songsList.AddRange(await GetSongsInFolderAsync(folder.Value.songs, folder.Value.folder).ConfigureAwait(false));
                 StorageApplicationPermissions.FutureAccessList.Remove(folder.Key);
             }

BreadPlayer.Views.UWP/SettingsViews/ViewModels/AccountsViewModel.cs

@@ -46,7 +46,7 @@ private async void LastfmLogout(object para)
         }
         private async void LastfmLogin(object para)
         {
-            if (!LastfmPassword.Any() || !LastfmUsername.Any())
+            if (string.IsNullOrEmpty(LastfmPassword) || string.IsNullOrEmpty(LastfmUsername))
             {
                 if ((bool)para)
                 {
@@ -148,8 +148,8 @@ public AccountsViewModel()
             _lyricSource = SettingsHelper.GetRoamingSetting<string>("LyricSource", "Auto");
             _lyricType = SettingsHelper.GetRoamingSetting<string>("LyricType", "Synced");
             _noOfArtistsToFetchInfoFor = SettingsHelper.GetRoamingSetting<string>("NoOfArtistsToFetchInfoFor", "Lead artist");
-            _lastfmPassword = SettingsHelper.GetRoamingSetting<string>("LastfmPassword", "");
-            _lastfmUsername = SettingsHelper.GetRoamingSetting<string>("LastfmUsername", "");
+            _lastfmPassword = SettingsHelper.GetRoamingSetting<string>("LastfmPassword", null);
+            _lastfmUsername = SettingsHelper.GetRoamingSetting<string>("LastfmUsername", null);
             LastfmLogin(false);
         }
     }