lint fixes

Author: brandonistfan

tcf_website/api/enrollment.py

@@ -1,15 +1,22 @@
+"""
+Module for fetching and updating section enrollment data asynchronously.
+"""
+
 import asyncio
-import requests
 import time
 from concurrent.futures import ThreadPoolExecutor
+
+import requests
 from django.utils import timezone
 from asgiref.sync import sync_to_async
+from django.http import HttpResponseNotFound
 
 from tcf_website.models import Section, SectionEnrollment, Semester, Course
 
 TIMEOUT = 10
 MAX_WORKERS = 5
 
+
 def fetch_section_data(section):
     """Fetch enrollment data for a given section from the UVA SIS API."""
     url = (
@@ -34,20 +41,24 @@ def fetch_section_data(section):
             }
     except requests.exceptions.RequestException as e:
         print(f"Network error while fetching section {section.sis_section_number}: {e}")
-    except Exception as e:
-        print(f"Unexpected error while fetching section {section.sis_section_number}: {e}")
-    
+    except ValueError as e:
+        print(f"JSON decoding error for section {section.sis_section_number}: {e}")
+
     return {}
 
 
 async def update_enrollment_data(course_id):
     """Asynchronous function to update enrollment data using ThreadPoolExecutor."""
     start_time = time.monotonic()
-    
+
+    if not await sync_to_async(Course.objects.filter(id=course_id).exists)():
+        return HttpResponseNotFound("Course not found.")
     course = await sync_to_async(Course.objects.get)(id=course_id)
     latest_semester = await sync_to_async(Semester.latest)()
-    sections = await sync_to_async(list)(Section.objects.filter(course=course, semester=latest_semester))
-    
+    sections = await sync_to_async(list)(
+        Section.objects.filter(course=course, semester=latest_semester)
+    )
+
     if not sections:
         print(f"No sections found for course {course.code()} in semester {latest_semester}.")
         return
@@ -68,20 +79,23 @@ async def process_section(section):
     await asyncio.gather(*(process_section(section) for section in sections))
 
     elapsed_time = time.monotonic() - start_time
-    print(f"Enrollment update completed at {timezone.now()} (Total time: {elapsed_time:.2f} seconds)")
+    print(f"Enrollment update completed at {timezone.now()} "
+          f"(Total time: {elapsed_time:.2f} seconds)")
 
 
 def update_section_enrollment(section, data):
     """Update SectionEnrollment safely within an async function."""
     section_enrollment, _ = SectionEnrollment.objects.get_or_create(section=section)
-    section_enrollment.enrollment_taken = data.get('enrollment_taken', 0)
-    section_enrollment.enrollment_limit = data.get('enrollment_limit', 0)
-    section_enrollment.waitlist_taken = data.get('waitlist_taken', 0)
-    section_enrollment.waitlist_limit = data.get('waitlist_limit', 0)
+    section_enrollment.enrollment_taken = data.get("enrollment_taken", 0)
+    section_enrollment.enrollment_limit = data.get("enrollment_limit", 0)
+    section_enrollment.waitlist_taken = data.get("waitlist_taken", 0)
+    section_enrollment.waitlist_limit = data.get("waitlist_limit", 0)
     section_enrollment.save()
-    
+
     print(
         f"Updated section {section.sis_section_number} | "
-        f"Enrollment: {section_enrollment.enrollment_taken}/{section_enrollment.enrollment_limit} | "
-        f"Waitlist: {section_enrollment.waitlist_taken}/{section_enrollment.waitlist_limit}"
+        f"Enrollment: {section_enrollment.enrollment_taken}/"
+        f"{section_enrollment.enrollment_limit} | "
+        f"Waitlist: {section_enrollment.waitlist_taken}/"
+        f"{section_enrollment.waitlist_limit}"
     )

tcf_website/views/browse.py

@@ -7,7 +7,6 @@
 from threading import Thread
 from typing import Any
 
-from django.core.cache import cache
 from django.core.exceptions import ObjectDoesNotExist
 from django.db.models import Avg, CharField, F, Q, Value
 from django.db.models.functions import Concat
@@ -281,15 +280,15 @@ def course_instructor(request, course_id, instructor_id, method="Most Recent"):
         for time in section.section_times.split(","):
             if len(time) > 0:
                 times.append(time)
-        
+
         section_enrollment = SectionEnrollment.objects.filter(section=section).first()
         enrollment_data = {
             'enrollment_taken': section_enrollment.enrollment_taken if section_enrollment else None,
             'enrollment_limit': section_enrollment.enrollment_limit if section_enrollment else None,
             'waitlist_taken': section_enrollment.waitlist_taken if section_enrollment else None,
             'waitlist_limit': section_enrollment.waitlist_limit if section_enrollment else None
         }
-        
+
         section_info["sections"][section.sis_section_number] = {
             "type": section.section_type,
             "units": section.units,