feat: add CapchaError exception and implement retry logic for capcha processing in MBBank classes

Author: thedtvn

mbbank/main.py

@@ -33,6 +33,9 @@ def __init__(self, err_out):
         self.message = err_out['message']
         super().__init__(f"{err_out['responseCode']} | {err_out['message']}")
 
+class CapchaError(MBBankError):
+    def __init__(self, err_out):
+        super().__init__(err_out)
 
 class MBBank:
     """Core class
@@ -180,7 +183,9 @@ def login(self, captcha_text: str):
             raise MBBankError(data_out["result"])
 
     def _authenticate(self):
-        while True:
+        try_count = 0
+        while try_count < self.retry_times:
+            try_count += 1
             self._userinfo = None
             self.sessionId = None
             self._temp = {}
@@ -192,6 +197,8 @@ def _authenticate(self):
                 if e.code == "GW283":
                     continue  # capcha error, try again
                 raise e
+        raise CapchaError(f"Exceeded maximum retry times for capcha processing ({self.retry_times})")
+        
 
     def _verify_biometric_check(self):
         self._req("https://online.mbbank.com.vn/api/retail-go-ekycms/v1.0/verify-biometric-nfc-transaction")

mbbank/mbasync.py

@@ -8,7 +8,7 @@
 import aiohttp
 
 from .capcha_ocr import CapchaProcessing
-from .main import MBBankError, MBBank
+from .main import MBBankError, MBBank, CapchaError
 from .wasm_helper import wasm_encrypt
 from .main import headers_default
 from .modals import BalanceResponseModal, BalanceLoyaltyResponseModal, BankListResponseModal, \
@@ -137,7 +137,8 @@ async def _verify_biometric_check(self):
         await self._req("https://online.mbbank.com.vn/api/retail-go-ekycms/v1.0/verify-biometric-nfc-transaction")
 
     async def _authenticate(self):
-        while True:
+        try_count = 0
+        while try_count < self.retry_times:
             self._userinfo = None
             self.sessionId = None
             self._temp = {}
@@ -151,6 +152,7 @@ async def _authenticate(self):
                 if e.code == "GW283":
                     continue  # capcha error, try again
                 raise e
+        raise CapchaError(f"Exceeded maximum retry times for capcha processing ({self.retry_times})")
 
     async def _req(self, url, *, json=None, headers=None):
         if headers is None: