Replies: 1 comment 1 reply
-
|
We just have to be careful to document it clearly, as on its own with a few chained ORs it's fine, but when a pseudo-nested AND gets added, which might even have additional ORs included it can easily get a bit confusing again. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
There are many cases when the decoders check for certain data at the same location of a parameter with different values.
For instance:
decoder/src/devices/CGD1_json.h
Line 10 in b752cfc
This could be possibly be simplified to use a json array. Using the example above:
"condition":["servicedata", "index", 0, "080caf", "|", "servicedata", "index", 0, "080c09", "|", "servicedata", "index", 0, "080cd0"]Could be potentially be converted to:
"condition":["servicedata", "index", 0, ["080caf", "080c09", "080cd0"]]This could be added as an extension to #99
Beta Was this translation helpful? Give feedback.
All reactions