fixed connectio nand spamming on deepresearch

Author: thefirehacker

lib/AIAssistant/AIAssistant-Backend.js

@@ -1513,6 +1513,15 @@ When user asks for something, generate creative, compact p5.js code that creates
   }
 
   async generateContent(prompt, type = 'creative') {
+    // Validate that AI session is properly established
+    if (!this.aiSession) {
+      throw new Error('AI session not established. Please connect to an AI provider first.');
+    }
+    
+    if (!this.aiSession.provider) {
+      throw new Error('AI session is missing provider information. Please reconnect to your AI provider.');
+    }
+    
     if (type === 'research' || type === 'general') {
       // For research and general generation, use general context instead of creative
       this.setChatMode('general');
@@ -1529,6 +1538,11 @@ When user asks for something, generate creative, compact p5.js code that creates
         let content = '';
 
         if (this.aiSession.provider === 'ollama') {
+          // Validate Ollama session has required properties
+          if (!this.aiSession.baseURL || !this.aiSession.model) {
+            throw new Error('Ollama session is incomplete. Missing baseURL or model. Please reconnect.');
+          }
+          
           // Use simple chat format for general/RAG responses
           const chatPrompt = `<|im_start|>system
 You are a helpful AI assistant. Provide clear, accurate, and informative responses based on the given context. Always respond in plain text format.<|im_end|>
@@ -1570,7 +1584,7 @@ ${userMessage}<|im_end|>
           content = data.response || '';
 
         } else {
-          throw new Error('Only Ollama provider is currently supported for general/research generation');
+          throw new Error(`Provider '${this.aiSession.provider}' is not currently supported for general/research generation`);
         }
 
         return content.trim();

lib/Pages/DeepResearch/deepresearch.js

@@ -696,9 +696,7 @@ class DeepResearchApp {
           const connectionAge = Date.now() - connectionData.timestamp;
           hasAI = connectionData.connected && connectionAge < (30 * 60 * 1000);
 
-          if (hasAI) {
-            console.log('🔄 Using stored AI connection state as fallback');
-          }
+          // Using stored AI connection state as fallback (logged once)
         }
       } catch (error) {
         console.warn('⚠️ Failed to check stored AI connection state:', error);

lib/Pages/Playground/playground.js

@@ -11,6 +11,8 @@ class PlaygroundApp {
     this.search = null; // Will be initialized with PlaygroundSearch
     this.isConnected = false;
     this.isResearching = false;
+    this.sharedListenerSetup = false;
+    this.lastConnectionMessageTime = 0;
 
     this.init();
   }
@@ -136,7 +138,12 @@ class PlaygroundApp {
             this.isConnected = true;
             this.updateStatus('aiStatus', `Connected (${currentProvider.provider})`, 'success');
             this.updateConnectButtonText();
-            this.addChatMessage('system', `🤖 Using existing AI connection (${currentProvider.provider}). Ready to help!`);
+            
+            // Only add message if we don't already have a recent connection message
+            if (!this.hasRecentConnectionMessage()) {
+              this.addChatMessage('system', `🤖 Using existing AI connection (${currentProvider.provider}). Ready to help!`);
+              this.lastConnectionMessageTime = Date.now();
+            }
           }
         } else {
           console.log('🔍 No active shared connection found after restoration check');
@@ -170,7 +177,7 @@ class PlaygroundApp {
   }
 
   setupSharedConnectionListener() {
-    if (window.SharedAIConnection) {
+    if (window.SharedAIConnection && !this.sharedListenerSetup) {
       // Listen for connection changes from other pages
       window.SharedAIConnection.addConnectionListener((event, data) => {
         console.log('🔄 Playground received shared connection event:', event, data);
@@ -183,7 +190,12 @@ class PlaygroundApp {
           this.isConnected = true;
           this.updateStatus('aiStatus', `Connected (${providerInfo.provider})`, 'success');
           this.updateConnectButtonText();
-          this.addChatMessage('system', `🤖 AI connected via ${providerInfo.provider}. Ready to help!`);
+          
+          // Only add message if we don't already have a recent connection message
+          if (!this.hasRecentConnectionMessage()) {
+            this.addChatMessage('system', `🤖 AI connected via ${providerInfo.provider}. Ready to help!`);
+            this.lastConnectionMessageTime = Date.now();
+          }
         } else if (event === 'disconnected') {
           this.isConnected = false;
           this.updateStatus('aiStatus', 'Ready to Connect', 'info');
@@ -196,6 +208,8 @@ class PlaygroundApp {
           this.addChatMessage('system', `❌ AI connection error: ${data.message}`);
         }
       });
+      
+      this.sharedListenerSetup = true;
     }
   }
 
@@ -229,7 +243,12 @@ class PlaygroundApp {
         this.isConnected = true;
         this.updateStatus('aiStatus', `Connected (${currentProvider.provider})`, 'success');
         this.updateConnectButtonText();
-        this.addChatMessage('system', `🤖 Using existing AI connection (${currentProvider.provider}). Ready to help!`);
+        
+        // Only add message if we don't already have a recent connection message
+        if (!this.hasRecentConnectionMessage()) {
+          this.addChatMessage('system', `🤖 Using existing AI connection (${currentProvider.provider}). Ready to help!`);
+          this.lastConnectionMessageTime = Date.now();
+        }
 
         connectButton.disabled = false;
         return;
@@ -250,7 +269,12 @@ class PlaygroundApp {
             this.isConnected = true;
             this.updateStatus('aiStatus', `Connected (${window.SharedAIConnection.currentProvider})`, 'success');
             this.updateConnectButtonText();
-            this.addChatMessage('system', `🤖 AI Assistant connected using ${window.SharedAIConnection.currentProvider}. Ready to help!`);
+            
+            // Only add message if we don't already have a recent connection message
+            if (!this.hasRecentConnectionMessage()) {
+              this.addChatMessage('system', `🤖 AI Assistant connected using ${window.SharedAIConnection.currentProvider}. Ready to help!`);
+              this.lastConnectionMessageTime = Date.now();
+            }
 
             connectButton.disabled = false;
           } else if (event === 'error') {
@@ -323,7 +347,12 @@ class PlaygroundApp {
       this.isConnected = true;
       this.updateStatus('aiStatus', `Connected (${status.provider})`, 'success');
       this.updateConnectButtonText();
-      this.addChatMessage('system', `🤖 AI Assistant connected using ${status.provider}. Ready to help!`);
+      
+      // Only add message if we don't already have a recent connection message
+      if (!this.hasRecentConnectionMessage()) {
+        this.addChatMessage('system', `🤖 AI Assistant connected using ${status.provider}. Ready to help!`);
+        this.lastConnectionMessageTime = Date.now();
+      }
     } else if (status.error) {
       this.isConnected = false;
       this.updateStatus('aiStatus', 'Connection Issue', 'error');
@@ -491,19 +520,43 @@ Based on the research, here are the key recommendations:
     input.value = '';
     input.style.height = 'auto';
 
-    // Check if AI is connected
-    if (!this.isConnected || !this.aiAssistant) {
+    // Enhanced AI connection validation
+    let aiAssistant = this.aiAssistant;
+    
+    // If local AI assistant is null, try to get from shared connection
+    if (!aiAssistant && window.SharedAIConnection && window.SharedAIConnection.isAIConnected()) {
+      console.log('🔍 Local AI assistant is null, trying shared connection...');
+      aiAssistant = window.SharedAIConnection.getAIAssistant();
+      if (aiAssistant) {
+        // Update our local reference
+        this.aiAssistant = aiAssistant;
+        this.aiAssistant.onStatusChange = (status) => this.handleAIStatusChange(status);
+        this.isConnected = true;
+        console.log('✅ Successfully retrieved AI assistant from shared connection');
+      }
+    }
+    
+    // Final validation - ensure we have both connection state and valid assistant
+    if (!this.isConnected || !aiAssistant) {
       this.addChatMessage('system', '⚠️ Please connect AI assistant first');
+      console.error('❌ Chat blocked: isConnected =', this.isConnected, ', aiAssistant =', !!aiAssistant);
       return;
     }
 
+    // Additional validation for AI assistant object
+    if (!aiAssistant.generateContent || typeof aiAssistant.generateContent !== 'function') {
+      this.addChatMessage('system', '❌ AI assistant is not properly initialized. Please reconnect.');
+      console.error('❌ AI assistant missing generateContent method:', aiAssistant);
+      return;
+    }
+
     try {
       // Check for document-related queries (RAG) using search module
       let response;
       if (this.search && this.search.isDocumentQuery(message)) {
         response = await this.search.handleRAGQuery(message);
       } else {
-        response = await this.aiAssistant.generateContent(message, 'general');
+        response = await aiAssistant.generateContent(message, 'general');
       }
 
       this.addChatMessage('assistant', response);
@@ -725,6 +778,11 @@ Based on the research, here are the key recommendations:
     return providerSelect ? providerSelect.value : 'AI';
   }
 
+  hasRecentConnectionMessage() {
+    // Check if we've added a connection message in the last 5 seconds
+    return (Date.now() - this.lastConnectionMessageTime) < 5000;
+  }
+  
   clearSuccessMessages() {
     // Clear any success banners
     const displayContent = document.getElementById('displayContent');

lib/Pages/Playground/search.js

@@ -61,7 +61,32 @@ class PlaygroundSearch {
       return "❌ RAG system not available. Please initialize the document store first.";
     }
 
-    return await this.sharedRAG.generateRAGResponse(query, this.app.aiAssistant);
+    // Enhanced AI assistant validation
+    let aiAssistant = this.app.aiAssistant;
+    
+    // If local AI assistant is null, try to get from shared connection
+    if (!aiAssistant && window.SharedAIConnection && window.SharedAIConnection.isAIConnected()) {
+      console.log('🔍 RAG: Local AI assistant is null, trying shared connection...');
+      aiAssistant = window.SharedAIConnection.getAIAssistant();
+      if (aiAssistant) {
+        // Update the app's local reference
+        this.app.aiAssistant = aiAssistant;
+        this.app.isConnected = true;
+        console.log('✅ RAG: Successfully retrieved AI assistant from shared connection');
+      }
+    }
+    
+    // Final validation
+    if (!aiAssistant) {
+      return "❌ AI assistant not available for document queries. Please connect an AI provider first.";
+    }
+    
+    // Additional validation for AI assistant object
+    if (!aiAssistant.generateContent || typeof aiAssistant.generateContent !== 'function') {
+      return "❌ AI assistant is not properly initialized. Please reconnect your AI provider.";
+    }
+
+    return await this.sharedRAG.generateRAGResponse(query, aiAssistant);
   }
 
   /**