Fix REX provider type #4434
Open
Fix REX provider type #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
Lennonka
approved these changes
Oct 28, 2025
Contributor
Lennonka
left a comment
Lennonka
left a comment
There was a problem hiding this comment.
LGTM
I guess this could be cherry picked farther, but I'm not sure how far. Can you check with someone, please?
Lennonka
added
style review done
10 tasks
| .. Assign the `Run Puppet Once {endash} SSH Default` job template. | ||
| . To run Puppet on hosts, execute a remote job and select category `Puppet` and template `Run Puppet Once - SSH Default`. | ||
| .. Assign the `Puppet Run Once {endash} Script Default` job template. | ||
| . To run Puppet on hosts, execute a remote job and select category `Puppet` and template `Puppet Run Once - Script Default`. |
Member
There was a problem hiding this comment.
Can you also look into this while you're here? #4189 (comment) It's part of #4192
* Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb * Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb * Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb * Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb Salt: No change in "guides/common/modules/proc_running-salt.adoc" but looked into this issue via PR 219 in foreman_salt. (Untested but verified that the templates are currently called "Salt Run function - SSH default". Clicking "Run Puppet once" in WebUI really causes REX to start a job that uses the "Puppet Run Once - Script Default" template. Tested on Foreman 3.16 Fixes theforeman#4415 (Rename REX provider)
maximiliankolb
force-pushed
the
fix_4415_SSH_provider
branch
from
9ef2617 to
268a56b
Compare
Contributor
Author
|
I checked on Foreman 3.16: 
The wording in the WebUI is weird! Can you please check if my second commit makes sense to you? @aneta-petrova |
"guides/common/modules/con_host-substatus-overview.adoc" remains unchanged because the wording seems to come from the WebUI. This makes vale happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Salt: No change in "guides/common/modules/proc_running-salt.adoc" but looked into this issue via PR 219 in foreman_salt. (Untested but verified that the templates are currently called "Salt Run function - SSH default".
Clicking "Run Puppet once" in WebUI really causes REX to start a job that uses the "Puppet Run Once - Script Default" template.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Fixes #4415 (Rename REX provider)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Tested on Foreman 3.16 but tech ACK would be appreciated.
Contributor checklists
Please cherry-pick my commits into: