Fixes #38718 - Register feature scope in belongs_to_proxy

Author: adamruzicka

app/models/concerns/belongs_to_proxies.rb

@@ -16,7 +16,7 @@ def belongs_to_proxy(name, options)
 
     def register_smart_proxy(name, options)
       self.registered_smart_proxies = registered_smart_proxies.merge(name => options)
-      belongs_to name, :class_name => 'SmartProxy'
+      belongs_to name, -> { with_features(options[:feature]) }, :class_name => 'SmartProxy'
       validates name, :proxy_features => { :feature => options[:feature], :required => options[:required] }
     end
 

app/validators/proxy_features_validator.rb

@@ -5,11 +5,13 @@ def initialize(args)
   end
 
   def validate_each(record, attribute, value)
-    if !value && @options[:required]
+    id = record.public_send("#{attribute}_id")
+    if !id && @options[:required]
       record.errors.add("#{attribute}_id", _('was not found'))
     end
 
-    if value && !value.has_feature?(@options[:feature])
+    # Due to scope being set on the association, it can happen that the id is present but the association is nil
+    if (id || value) && !value.try(:has_feature?, @options[:feature])
       if @options[:message].nil?
         message = _('does not have the %s feature') % @options[:feature]
       else

test/controllers/subnets_controller_test.rb

@@ -16,11 +16,11 @@ class SubnetsControllerTest < ActionController::TestCase
   context 'three similar subnets exists' do
     def setup
       as_admin do
-        @s1 = FactoryBot.create(:subnet_ipv4, :network => '100.20.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
-        @s3 = FactoryBot.create(:subnet_ipv4, :network => '200.100.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
-        @s2 = FactoryBot.create(:subnet_ipv4, :network => '100.100.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
-        @s4 = FactoryBot.create(:subnet_ipv6, :network => 'beef::', :cidr => '64', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
-        @s5 = FactoryBot.create(:subnet_ipv6, :network => 'ffee::', :cidr => '64', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
+        @s1 = FactoryBot.create(:subnet_ipv4, :dhcp, :network => '100.20.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
+        @s3 = FactoryBot.create(:subnet_ipv4, :dhcp, :network => '200.100.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
+        @s2 = FactoryBot.create(:subnet_ipv4, :dhcp, :network => '100.100.100.100', :cidr => '24', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
+        @s4 = FactoryBot.create(:subnet_ipv6, :dhcp, :network => 'beef::', :cidr => '64', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
+        @s5 = FactoryBot.create(:subnet_ipv6, :dhcp, :network => 'ffee::', :cidr => '64', :organization_ids => [taxonomies(:organization1).id], :location_ids => [taxonomies(:location1).id])
       end
     end
 

test/models/concerns/belongs_to_proxies_test.rb

@@ -5,7 +5,7 @@ class SampleModel
     include BelongsToProxies
 
     class << self
-      def belongs_to(name, options = {})
+      def belongs_to(name, scope, options = {})
       end
 
       def validates(name, options = {})

test/unit/validators/proxy_features_validator_test.rb

@@ -4,7 +4,7 @@ class ProxyFeaturesValidatorTest < ActiveSupport::TestCase
   class Validatable
     include ActiveModel::Validations
     validates :proxy, :proxy_features => { :feature => 'DNS' }
-    attr_accessor :proxy
+    attr_accessor :proxy, :proxy_id
   end
 
   def setup
@@ -21,4 +21,10 @@ def setup
     refute_valid @validatable
     assert_equal ['does not have the DNS feature'], @validatable.errors[:proxy_id]
   end
+
+  test 'should fail when id is present but association returns nil' do
+    @validatable.proxy_id = FactoryBot.create(:dhcp_smart_proxy).id
+    refute_valid @validatable
+    assert_equal ['does not have the DNS feature'], @validatable.errors[:proxy_id]
+  end
 end