Skip to content

Commit f320215

Browse files
committed
wip: Drop superfluous includes
The authorizer buils a query like where taxonomy scoping is done by subqueries. Including includes for taxonomies feels superfluous and in some places can lead to returning duplicate results.
1 parent 88563ef commit f320215

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/services/authorizer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def build_filtered_scope_components(resource_class, all_filters, options)
109109
find_options = ScopedSearch::QueryBuilder.build_query(resource_class.scoped_search_definition, search_string, options)
110110

111111
result[:where] << find_options[:conditions]
112-
result[:includes].push(*find_options[:include])
112+
# result[:includes].push(*find_options[:include])
113113
result[:joins].push(*find_options[:joins])
114114
rescue ScopedSearch::QueryNotSupported => e
115115
Foreman::Logging.logger('permissions').error "Scoped search query not supported: #{e.message}"

0 commit comments

Comments
 (0)