Use: Rebuild only if host powered off

Use theforeman/foreman#10860 and refactor
the vsphere/proxmox methods as it is no longer needed to
start/stop/reboot

Author: sbernhard

app/models/concerns/foreman_bootdisk/compute_resources/proxmox.rb

@@ -27,7 +27,6 @@ def iso_attach(iso, vm_uuid)
         disks = server.disks.map { |disk| disk.split(":")[0] }.join(";")
         server.update({ ide2: "#{volume.volid},media=cdrom" })
         server.update({ boot: "order=ide2;#{disks}" })
-        server.reboot
       end
 
       def iso_detach(vm_uuid)

app/models/concerns/foreman_bootdisk/compute_resources/vmware.rb

@@ -42,11 +42,7 @@ def iso_attach(iso, vm_uuid)
           'allow_guest_control' => true,
           'controller_key' => controller[:key]
         }
-	vm = find_vm_by_uuid(vm_uuid)
-	vm.stop if vm.ready?
-	vm.reload
         client.vm_reconfig_cdrom options
-	vm.start if !vm.ready?
       end
 
       def iso_detach(vm_uuid)

app/models/concerns/foreman_bootdisk/host_ext.rb

@@ -31,6 +31,10 @@ def bootdisk_downloadable?
       architecture.blank? || intel_arch?
     end
 
+    def bootdisk_rebuild_requires_poweroff
+      true
+    end
+
     def intel_arch?
       /i.86|x86[_-]64/ =~ architecture.name
     end