Enzyme does not exist for React > v16

[nadjaheitmann]

foreman_plugin_template/webpack/test_setup.js

Line 6 in 268e2b4

import Adapter from 'enzyme-adapter-react-16';

This seems a bit outdated and should be removed (https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl)

[ekohl]

@MariaAga is opened https://community.theforeman.org/t/how-do-we-do-ui-tests-and-should-we-continue-that-way/42983 about this.

[MariaAga]

We cant move to react 17+ until we remove enzyme which will take awhile and does not look to be a priority currently

[ekohl]

We cant move to react 17+ until we remove enzyme which will take awhile and does not look to be a priority currently

I'd say that this shouldn't hold anyone back who wants to work on it. Just that currently nobody is known to focus on it.

[MariaAga]

Right, but it will probably be an effort for many people (and not just one person) as we need to replace all snapshot tests from all plugins + foreman core

[ekohl]

Perhaps we can update the plugin template to at least signal it should no longer be used? Even if it's not often people use it, I see the plugin template also as a best practice reference.

[nadjaheitmann]

Thanks for pointing out the discourse thread. I think I have seen it before but it slipped my mind. I just stumbled across the issue because we also have some JS tests using enzyme and my pipeline failed (it uses the Foreman template), so I was trying to track down where issue would come from.