SAT-37395 - Don't make API call for cveColumn if non-iop

Author: chris1984

webpack/InsightsVulnerabilityHostIndexExtensions/CVECountCell.js

@@ -3,25 +3,31 @@ import PropTypes from 'prop-types';
 import { UnknownIcon } from '@patternfly/react-icons';
 import { Link } from 'react-router-dom';
 import { useAPI } from 'foremanReact/common/hooks/API/APIHooks';
-
 import { insightsCloudUrl } from '../InsightsCloudSync/InsightsCloudSyncHelpers';
+import { useAdvisorEngineConfig } from '../common/Hooks/ConfigHooks';
 
 const vulnerabilityApiPath = path =>
   insightsCloudUrl(`api/vulnerability/v1/${path}`);
 
 export const CVECountCell = ({ hostDetails }) => {
+  const isIopEnabled = useAdvisorEngineConfig();
+
   // eslint-disable-next-line camelcase
   const uuid = hostDetails?.subscription_facet_attributes?.uuid;
 
   const key = `HOST_CVE_COUNT_${uuid}`;
   const response = useAPI(
-    uuid ? 'get' : null,
+    isIopEnabled && uuid ? 'get' : null,
     vulnerabilityApiPath(`systems?uuid=${uuid}`),
     {
       key,
     }
   );
 
+  if (!isIopEnabled) {
+    return <UnknownIcon />;
+  }
+
   if (uuid === undefined) {
     return <UnknownIcon />;
   }

webpack/InsightsVulnerabilityHostIndexExtensions/__tests__/CVECountCell.test.js

@@ -2,8 +2,11 @@ import React from 'react';
 import { render, screen } from '@testing-library/react';
 import { API } from 'foremanReact/redux/API';
 import { CVECountCell } from '../CVECountCell';
+import * as ConfigHooks from '../../common/Hooks/ConfigHooks';
 
 jest.mock('foremanReact/redux/API');
+jest.mock('../../common/Hooks/ConfigHooks');
+
 API.get.mockImplementation(async () => ({
   data: [
     {
@@ -14,15 +17,62 @@ API.get.mockImplementation(async () => ({
   ],
 }));
 
+const hostDetailsMock = {
+      name: 'test-host.example.com',
+      subscription_facet_attributes: {
+        uuid: 'test-uuid-123',
+      },
+    };
+
 describe('CVECountCell', () => {
-  it('renders an empty cves count column', () => {
-    const hostDetailsMock = {
+  beforeEach(() => {
+    ConfigHooks.useAdvisorEngineConfig.mockReturnValue(true);
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('renders an empty cves count column when no subscription UUID', () => {
+    const hostDetailsMockIoP = {
       name: 'test-host.example.com',
       subscription_facet_attributes: {
         uuid: null, // no subscription
       },
     };
+    render(<CVECountCell hostDetails={hostDetailsMockIoP} />);
+    expect(screen.getByRole('img', { hidden: true })).toBeTruthy();
+  });
+
+  it('renders UnknownIcon when IoP is not enabled', () => {
+    ConfigHooks.useAdvisorEngineConfig.mockReturnValue(false);
+    
+    render(<CVECountCell hostDetails={hostDetailsMock} />);
+    expect(screen.getByRole('img', { hidden: true })).toBeTruthy();
+    expect(ConfigHooks.useAdvisorEngineConfig).toHaveBeenCalled();
+  });
+
+  it('renders UnknownIcon when IoP is enabled but CVE API call fails', () => {
+    // Mock successful IoP config
+    ConfigHooks.useAdvisorEngineConfig.mockReturnValue(true);
+    
+    // Mock CVE API failure - override the global mock for this test
+    API.get.mockImplementationOnce(async () => {
+      throw new Error('CVE API call failed');
+    });
+
+    render(<CVECountCell hostDetails={hostDetailsMock} />);
+    
+    // Should render UnknownIcon when CVE API fails
+    expect(screen.getByRole('img', { hidden: true })).toBeTruthy();
+    expect(ConfigHooks.useAdvisorEngineConfig).toHaveBeenCalled();
+  });
+
+  it('renders UnknownIcon when IoP is undefined (API call pending)', () => {
+    ConfigHooks.useAdvisorEngineConfig.mockReturnValue(undefined);
+    
     render(<CVECountCell hostDetails={hostDetailsMock} />);
     expect(screen.getByRole('img', { hidden: true })).toBeTruthy();
+    expect(ConfigHooks.useAdvisorEngineConfig).toHaveBeenCalled();
   });
 });