-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
When parameter persistence is enabled (OBSAH_PERSIST_PARAMS=true), invalid parameters are written to parameters.yaml without validation . This causes the invalid values to persist across runs, forcing users to encounter the same validation errors on every subsequent execution until they manually edit or reset the parameter.
Steps to Reproduce
- Enable parameter persistence:
OBSAH_PERSIST_PARAMS=true - Run a command with an invalid parameter:
./foremanctl deploy --add-feature invalid-feature
- Observe that:
- The invalid value
invalid-featureis written toparameters.yaml - A validation error is displayed to the user
- The command exits with an error
- The invalid value
- Run the command again without any parameters:
./foremanctl deploy
- The same validation error occurs because
invalid-featureis loaded fromparameters.yaml
Similar issue can be see while Setting tuning higher than the system supports as they persists and blocks all later deployments
Expected Behavior
Parameters should only be persisted after successful validation. If validation fails, the parameter file should remain unchanged.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels