Fix Lint/NonAtomicFileOperation

Result of:

    rubocop --autocorrect-all --only Lint/NonAtomicFileOperation

This also fixes some deprecated uses of File.exists?

Author: ekohl

lib/puppet/provider/katello_ssl_tool.rb

@@ -20,7 +20,7 @@ def create
 
     def destroy
       files_to_deploy.each do |file|
-        File.delete(file) if File.exist?(file)
+        FileUtils.rm_f(file)
       end
 
       output = execute([:rpm, '-q', rpmfile_base_name], failonfail: false)
@@ -53,9 +53,7 @@ def katello_ssl_tool(*args)
     end
 
     def generate!
-      if File.exists?(update_file)
-        File.delete(update_file)
-      end
+      FileUtils.rm_f(update_file)
     end
 
     def generate?
@@ -189,7 +187,7 @@ def create
     end
 
     def destroy
-      File.delete(resource[:path]) if File.exist?(resource[:path])
+      FileUtils.rm_f(resource[:path])
     end
 
     protected

lib/puppet/provider/privkey/katello_ssl_tool.rb

@@ -14,7 +14,7 @@ def expected_content
                 '-passin', "file:#{resource[:password_file]}")
         File.read(tmp_file)
       ensure
-        File.delete(tmp_file) if File.exists?(tmp_file)
+        FileUtils.rm_f(tmp_file)
       end
     else
       super