Skip to content

Commit 2a33a2a

Browse files
ekohlehelms
authored andcommitted
Remove redundant Optional data types
When a parameter has a default, there is no way to set it back to undef. That means the Optional part is redundant and the data type can be simplified.
1 parent 063dedc commit 2a33a2a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

manifests/init.pp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -376,12 +376,12 @@
376376
Optional[String] $dhcp_peer_address = undef,
377377
Enum['standalone', 'primary', 'secondary'] $dhcp_node_type = 'standalone',
378378
Optional[String] $dhcp_failover_address = $foreman_proxy::params::dhcp_failover_address,
379-
Optional[Stdlib::Port] $dhcp_failover_port = 519,
380-
Optional[Integer[0]] $dhcp_max_response_delay = 30,
381-
Optional[Integer[0]] $dhcp_max_unacked_updates = 10,
382-
Optional[Integer[0]] $dhcp_mclt = 300,
383-
Optional[Integer[0, 255]] $dhcp_load_split = 255,
384-
Optional[Integer[0]] $dhcp_load_balance = 3,
379+
Stdlib::Port $dhcp_failover_port = 519,
380+
Integer[0] $dhcp_max_response_delay = 30,
381+
Integer[0] $dhcp_max_unacked_updates = 10,
382+
Integer[0] $dhcp_mclt = 300,
383+
Integer[0, 255] $dhcp_load_split = 255,
384+
Integer[0] $dhcp_load_balance = 3,
385385
Boolean $dhcp_manage_acls = $foreman_proxy::params::dhcp_manage_acls,
386386
Boolean $dns = false,
387387
Foreman_proxy::ListenOn $dns_listen_on = 'https',

0 commit comments

Comments
 (0)