add remote_file::{owner,group} optional params

Author: jhoblitt

manifests/remote_file.pp

@@ -3,6 +3,8 @@
 define foreman_proxy::remote_file (
   Stdlib::Filesource $remote_location,
   Stdlib::Filemode $mode = '0644',
+  Optional[String[1]] $owner = undef,
+  Optional[String[1]] $group = undef,
 ) {
   $parent = dirname($title)
   File <| title == $parent |>
@@ -13,6 +15,8 @@
   -> file { $title:
     source  => $remote_location,
     mode    => $mode,
+    owner   => $owner,
+    group   => $group,
     replace => false,
   }
 }

spec/defines/foreman_proxy_remote_file_spec.rb

@@ -1,31 +1,64 @@
 require 'spec_helper'
 
+shared_examples 'remote_file' do
+  it { is_expected.to contain_exec('mkdir -p /tmp') }
+end
+
 describe 'foreman_proxy::remote_file' do
   let(:title) { '/tmp/a' }
 
-  let(:params) do
-    {
-      remote_location: 'https://example.com/tmp/a',
-      mode: '0664'
-    }
-  end
+  context 'without owner/group params' do
+    let(:params) do
+      {
+        remote_location: 'https://example.com/tmp/a',
+        mode: '0664'
+      }
+    end
 
-  context 'default scenario' do
-    it { is_expected.to contain_exec('mkdir -p /tmp') }
+    context 'default scenario' do
+      include_examples 'remote_file'
 
-    it do
-      is_expected.to contain_file('/tmp/a')
-        .with_source('https://example.com/tmp/a')
-        .with_mode('0664')
-        .that_requires('Exec[mkdir -p /tmp]')
+      it do
+        is_expected.to contain_file('/tmp/a').with(
+          source: 'https://example.com/tmp/a',
+          mode: '0664',
+          owner: nil,
+          group: nil,
+        ).without(
+        ).that_requires('Exec[mkdir -p /tmp]')
+      end
+    end
+
+    context 'with parent file defined' do
+      let :pre_condition do
+        "file { '/tmp': }"
+      end
+
+      include_examples 'remote_file'
+
+      it { is_expected.to contain_exec('mkdir -p /tmp').that_requires('File[/tmp]') }
     end
   end
 
-  context 'with parent file defined' do
-    let :pre_condition do
-      "file { '/tmp': }"
+  context 'with owner/group params' do
+    let(:params) do
+      {
+        remote_location: 'https://example.com/tmp/a',
+        mode: '0664',
+        owner: 'foo',
+        group: 'bar',
+      }
     end
 
-    it { is_expected.to contain_exec('mkdir -p /tmp').that_requires('File[/tmp]') }
+    include_examples 'remote_file'
+
+    it do
+      is_expected.to contain_file('/tmp/a').with(
+        source: 'https://example.com/tmp/a',
+        mode: '0664',
+        owner: 'foo',
+        group: 'bar',
+      ).that_requires('Exec[mkdir -p /tmp]')
+    end
   end
 end