Fixes #33864 - disable registration module by default

Author: evgeni

manifests/init.pp

@@ -329,7 +329,7 @@
   Boolean $templates = false,
   Foreman_proxy::ListenOn $templates_listen_on = 'both',
   Stdlib::HTTPUrl $template_url = $foreman_proxy::params::template_url,
-  Boolean $registration = true,
+  Boolean $registration = false,
   Foreman_proxy::ListenOn $registration_listen_on = 'https',
   Boolean $logs = true,
   Foreman_proxy::ListenOn $logs_listen_on = 'https',

spec/classes/foreman_proxy__register__spec.rb

@@ -44,7 +44,7 @@
           before { subject.resource('Datacat_collector[foreman_proxy::enabled_features]').provider.exists? }
 
           it 'should populate features on foreman_smartproxy' do
-            expect(subject.resource("Foreman_smartproxy[#{facts[:fqdn]}]").parameters[:features].should.sort).to match_array(["Logs", "Puppet", "Puppet CA", "Registration"])
+            expect(subject.resource("Foreman_smartproxy[#{facts[:fqdn]}]").parameters[:features].should.sort).to match_array(["Logs", "Puppet", "Puppet CA"])
           end
         end
       end

spec/classes/foreman_proxy__spec.rb

@@ -307,6 +307,13 @@
           ])
         end
 
+        it 'should generate correct registration.yml' do
+          verify_exact_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/registration.yml", [
+            '---',
+            ':enabled: false',
+          ])
+        end
+
         it 'should generate correct logs.yml' do
           verify_exact_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/logs.yml", [
             '---',
@@ -808,6 +815,40 @@
         end
       end
 
+      context 'with registration => true' do
+        let(:params) { super().merge(registration: true) }
+
+        context 'with feature on http' do
+          let(:params) { super().merge(registration_listen_on: 'http') }
+
+          it 'should set enabled to http' do
+            verify_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/registration.yml", [
+              ':enabled: http',
+            ])
+          end
+        end
+
+        context 'with feature on https' do
+          let(:params) { super().merge(registration_listen_on: 'https') }
+
+          it 'should set enabled to https' do
+            verify_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/registration.yml", [
+              ':enabled: https',
+            ])
+          end
+        end
+
+        context 'with feature on both' do
+          let(:params) { super().merge(registration_listen_on: 'both') }
+
+          it 'should set enabled to true' do
+            verify_contents(catalogue, "#{etc_dir}/foreman-proxy/settings.d/registration.yml", [
+              ':enabled: true',
+            ])
+          end
+        end
+      end
+
       context 'when log_level => DEBUG' do
         let(:params) { super().merge(log_level: 'DEBUG') }