Refs #34239 - Use mode parameter for remote_execution_ssh plugin

The old async_ssh setting is now configured by setting the value of the
newly introduced mode parameter to ssh-async. See the commit which
introduced this change for more information:
theforeman/smart_proxy_remote_execution_ssh@611f315

This is part of version 0.5.0, which is included since Foreman 3.1.

Author: wbclark

manifests/plugin/remote_execution/ssh.pp

@@ -4,6 +4,8 @@
 #
 # === Parameters:
 #
+# $mode::               Operation Mode of the plugin.
+#
 # $generate_keys::      Automatically generate SSH keys
 #
 # $install_key::        Automatically install generated SSH key to root authorized keys
@@ -27,8 +29,6 @@
 #
 # $listen_on::          Proxy feature listens on https, http, or both
 #
-# $async_ssh::          Whether to run remote execution jobs asynchronously.
-#
 class foreman_proxy::plugin::remote_execution::ssh (
   Boolean $enabled = true,
   Foreman_proxy::ListenOn $listen_on = 'https',
@@ -40,7 +40,7 @@
   Stdlib::Absolutepath $local_working_dir = '/var/tmp',
   Stdlib::Absolutepath $remote_working_dir = '/var/tmp',
   Boolean $ssh_kerberos_auth = false,
-  Boolean $async_ssh = false,
+  Enum['ssh', 'ssh-async'] $mode = 'ssh'
 ) {
 
   $ssh_identity_path = "${ssh_identity_dir}/${ssh_identity_file}"

spec/classes/foreman_proxy__plugin__remote_execution__ssh_spec.rb

@@ -43,7 +43,7 @@
           :ssh_identity_file  => 'id_rsa',
           :install_key        => true,
           :ssh_kerberos_auth  => true,
-          :async_ssh          => true,
+          :mode               => 'ssh-async',
         } end
 
         it { should contain_class('foreman_proxy::plugin::dynflow') }
@@ -56,7 +56,7 @@
             with_content(%r{:local_working_dir: /tmp}).
             with_content(%r{:remote_working_dir: /tmp}).
             with_content(%r{:kerberos_auth: true}).
-            with_content(%r{:async_ssh: true}).
+            with_content(%r{:mode: ssh-async}).
             with({
               :ensure  => 'file',
               :owner   => 'root',

templates/plugin/remote_execution_ssh.yml.erb

@@ -6,4 +6,4 @@
 :kerberos_auth: <%= scope.lookupvar('::foreman_proxy::plugin::remote_execution::ssh::ssh_kerberos_auth') %>
 
 # Whether to run remote execution jobs asynchronously
-:async_ssh: <%= scope.lookupvar("::foreman_proxy::plugin::remote_execution::ssh::async_ssh") %>
+:mode: <%= scope.lookupvar("::foreman_proxy::plugin::remote_execution::ssh::mode") %>