Remove localconfig (see PUP-880)

https://puppet.atlassian.net/browse/PUP-880

(PUP-880) Remove localconfig setting

The localconfig setting wasn't used anywhere so remove it, including
references in sample puppet.conf files for various distros.

Author: Mike Massonnet

manifests/agent/config.pp

@@ -3,7 +3,6 @@
 class puppet::agent::config inherits puppet::config {
   puppet::config::agent {
     'classfile':         value => $puppet::classfile;
-    'localconfig':       value => $puppet::localconfig;
     'default_schedules': value => $puppet::agent_default_schedules;
     'report':            value => $puppet::report;
     'masterport':        value => $puppet::agent_server_port;

manifests/init.pp

@@ -97,8 +97,6 @@
 #
 # $hiera_config::                           The hiera configuration file.
 #
-# $localconfig::                            The localconfig setting.
-#
 # $syslogfacility::                         Facility name to use when logging to syslog
 #
 # $use_srv_records::                        Whether DNS SRV records will be used to resolve
@@ -633,7 +631,6 @@
   Optional[String] $agent_restart_command = $puppet::params::agent_restart_command,
   String $classfile = $puppet::params::classfile,
   String $hiera_config = $puppet::params::hiera_config,
-  String $localconfig = $puppet::params::localconfig,
   Boolean $allow_any_crl_auth = $puppet::params::allow_any_crl_auth,
   Array[String] $auth_allowed = $puppet::params::auth_allowed,
   Variant[String, Array[String]] $client_package = $puppet::params::client_package,

manifests/params.pp

@@ -22,7 +22,6 @@
   $show_diff           = false
   $module_repository   = undef
   $hiera_config        = '$confdir/hiera.yaml'
-  $localconfig         = '$vardir/localconfig'
   $usecacheonfailure   = true
   $ca_server           = undef
   $ca_port             = undef