Make pluginsource, pluginfactsource and classfile optional

These parameters have a sane default and doesn't need to be in the
config.

Author: ekohl

manifests/agent/config.pp

@@ -2,7 +2,6 @@
 # @api private
 class puppet::agent::config inherits puppet::config {
   puppet::config::agent{
-    'classfile':         value => $puppet::classfile;
     'localconfig':       value => '$vardir/localconfig';
     'default_schedules': value => false;
     'report':            value => $puppet::report;
@@ -14,6 +13,11 @@
     'noop':              value => $puppet::agent_noop;
     'usecacheonfailure': value => $puppet::usecacheonfailure;
   }
+  if $puppet::classfile {
+    puppet::config::agent {
+      'classfile':         value => $puppet::classfile;
+    }
+  }
   if $puppet::http_connect_timeout != undef {
     puppet::config::agent {
       'http_connect_timeout': value => $puppet::http_connect_timeout;

manifests/init.pp

@@ -603,12 +603,12 @@
   Array[String] $dns_alt_names = $puppet::params::dns_alt_names,
   Boolean $use_srv_records = $puppet::params::use_srv_records,
   Optional[String] $srv_domain = $puppet::params::srv_domain,
-  String $pluginsource = $puppet::params::pluginsource,
-  String $pluginfactsource = $puppet::params::pluginfactsource,
+  Optional[String] $pluginsource = $puppet::params::pluginsource,
+  Optional[String] $pluginfactsource = $puppet::params::pluginfactsource,
   Hash[String, Data] $additional_settings = $puppet::params::additional_settings,
   Hash[String, Data] $agent_additional_settings = $puppet::params::agent_additional_settings,
   Optional[String] $agent_restart_command = $puppet::params::agent_restart_command,
-  String $classfile = $puppet::params::classfile,
+  Optional[String] $classfile = $puppet::params::classfile,
   String $hiera_config = $puppet::params::hiera_config,
   String $auth_template = $puppet::params::auth_template,
   Boolean $allow_any_crl_auth = $puppet::params::allow_any_crl_auth,

manifests/params.pp

@@ -35,11 +35,9 @@
   $use_srv_records     = false
   $srv_domain          = fact('networking.domain')
 
-  # lint:ignore:puppet_url_without_modules
-  $pluginsource        = 'puppet:///plugins'
-  $pluginfactsource    = 'puppet:///pluginfacts'
-  # lint:endignore
-  $classfile           = '$statedir/classes.txt'
+  $pluginsource        = undef
+  $pluginfactsource    = undef
+  $classfile           = undef
   $syslogfacility      = undef
   $environment         = $::environment