Add unmanaged Puppet Agent runmode

Fixes GH-383

Author: Rathios

manifests/agent/service.pp

@@ -18,7 +18,7 @@
       $cron_enabled = false
       $systemd_enabled = true
     }
-    'none': {
+    'none', 'unmanaged': {
       $service_enabled = false
       $cron_enabled = false
       $systemd_enabled = false

manifests/agent/service/cron.pp

@@ -3,7 +3,7 @@
 class puppet::agent::service::cron (
   Boolean $enabled = false,
 ) {
-  unless 'cron' in $::puppet::unavailable_runmodes {
+  unless $::puppet::runmode == 'unmanaged' or 'cron' in $::puppet::unavailable_runmodes {
     if $enabled {
       $command = pick($::puppet::cron_cmd, "${::puppet::puppet_cmd} agent --config ${::puppet::dir}/puppet.conf --onetime --no-daemonize")
       $times = extlib::ip_to_cron($::puppet::runinterval)

manifests/agent/service/daemon.pp

@@ -3,7 +3,7 @@
 class puppet::agent::service::daemon (
   Boolean $enabled = false,
 ) {
-  unless 'service' in $::puppet::unavailable_runmodes {
+  unless $::puppet::runmode == 'unmanaged' or 'service' in $::puppet::unavailable_runmodes {
     if $enabled {
       service {'puppet':
         ensure     => running,

manifests/agent/service/systemd.pp

@@ -3,7 +3,7 @@
 class puppet::agent::service::systemd (
   Boolean $enabled = false,
 ) {
-  unless 'systemd.timer' in $::puppet::unavailable_runmodes {
+  unless $::puppet::runmode == 'unmanaged' or 'systemd.timer' in $::puppet::unavailable_runmodes {
     exec { 'systemctl-daemon-reload-puppet':
       refreshonly => true,
       path        => $::path,

manifests/init.pp

@@ -559,7 +559,7 @@
   Optional[String] $autosign_source = $puppet::params::autosign_source,
   Variant[Integer[0],Pattern[/^\d+[smhdy]?$/]] $runinterval = $puppet::params::runinterval,
   Boolean $usecacheonfailure = $puppet::params::usecacheonfailure,
-  Enum['cron', 'service', 'systemd.timer', 'none'] $runmode = $puppet::params::runmode,
+  Enum['cron', 'service', 'systemd.timer', 'none', 'unmanaged'] $runmode = $puppet::params::runmode,
   Array[Enum['cron', 'service', 'systemd.timer', 'none']] $unavailable_runmodes = $puppet::params::unavailable_runmodes,
   Optional[String] $cron_cmd = $puppet::params::cron_cmd,
   Optional[String] $systemd_cmd = $puppet::params::systemd_cmd,

spec/classes/puppet_agent_spec.rb

@@ -308,6 +308,23 @@
             it { is_expected.not_to contain_service('puppet-run.timer') }
           end
         end
+
+        describe 'when runmode => unmanaged' do
+          let :params do
+            super().merge(runmode: 'unmanaged')
+          end
+
+          # For windows we specify a package provider which doesn't compile
+          if facts[:osfamily] != 'windows'
+            it { is_expected.to compile.with_all_deps }
+          end
+          it { is_expected.to contain_class('puppet::agent::service::daemon').with_enabled(false) }
+          it { is_expected.to contain_class('puppet::agent::service::cron').with_enabled(false) }
+          it { is_expected.to contain_class('puppet::agent::service::systemd').with_enabled(false) }
+          it { is_expected.not_to contain_cron('puppet') }
+          it { is_expected.not_to contain_service('puppet') }
+          it { is_expected.not_to contain_service('puppet-run.timer') }
+        end
       end
 
       describe 'when unavailable_runmodes => ["cron"]' do