Set data types on config defines

Author: ekohl

manifests/config/agent.pp

@@ -1,7 +1,7 @@
 define puppet::config::agent (
-  $value,
-  $key    = $name,
-  $joiner = ','
+  Variant[Array[String], Boolean, String, Integer] $value,
+  String $key    = $name,
+  String $joiner = ','
 ) {
   puppet::config::entry{"agent_${name}":
     key          => $key,

manifests/config/entry.pp

@@ -1,9 +1,9 @@
 define puppet::config::entry (
-  $key,
-  $value,
-  $section,
-  $sectionorder = 5,
-  $joiner       = ',',
+  String $key,
+  Variant[Array[String], Boolean, String, Integer] $value,
+  String $section,
+  Variant[Integer[0], String] $sectionorder = 5,
+  String $joiner       = ',',
 ) {
   if ($value =~ Array) {
     $_value = join(flatten($value), $joiner)

manifests/config/main.pp

@@ -1,7 +1,7 @@
 define puppet::config::main (
-  $value,
-  $key    = $name,
-  $joiner = ','
+  Variant[Array[String], Boolean, String, Integer] $value,
+  String $key    = $name,
+  String $joiner = ','
 ) {
   puppet::config::entry{"main${name}":
     key          => $key,

manifests/config/master.pp

@@ -1,7 +1,7 @@
 define puppet::config::master (
-  $value,
-  $key    = $name,
-  $joiner = ','
+  Variant[Array[String], Boolean, String, Integer] $value,
+  String $key    = $name,
+  String $joiner = ','
 ) {
   puppet::config::entry{"master_${name}":
     key          => $key,