puppet agent timer: depend on network/start it if offline #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes: With adding network-online.target as dependency we ensure that the network is really available. That might not be the case for the network.target. In case the system has no proper network manager, network-online.target isn't available. For that situation we still depend on network.target. Also we now have Wants= defined. That will start the targets if the agent is started. We had a similar discussion upstream: puppetlabs/puppet#8893
|
I wonder if we should push the timer upstream. |
|
I'm wondering why the My biggest "fear" (hard word) here is: a user has intentionally dropped out of |
|
(depending on the discussion, we could squeeze that in into #834 ;)) |
|
@bastelfreak since you linked the PR to me, any idea about what @evgeni said? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes: With adding network-online.target as dependency we ensure
that the network is really available. That might not be the case for the
network.target. In case the system has no proper network manager,
network-online.target isn't available. For that situation we still
depend on network.target. Also we now have Wants= defined. That will
start the targets if the agent is started.
We had a similar discussion upstream:
puppetlabs/puppet#8893