Skip to content

Commit 07c6231

Browse files
committed
Make dynflow an explicit dependency
Loading the smart_proxy_dynflow (or any Smart Proxy plugin really) in load_classes does not work due to the way plugin initialization happens. For this plugin to work, dynflow must be running. This uses requires to validate that dynflow is actually correctly enabled and running. This also means that if dynflow was loaded but ended up in a failed state that REX SSH also ends up in a failed state.
1 parent 271fbef commit 07c6231

File tree

1 file changed

+2
-1
lines changed
  • lib/smart_proxy_remote_execution_ssh

1 file changed

+2
-1
lines changed

lib/smart_proxy_remote_execution_ssh/plugin.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ class Plugin < Proxy::Plugin
3232

3333
plugin :ssh, Proxy::RemoteExecution::Ssh::VERSION
3434

35+
requires :dynflow, '~> 0.5'
36+
3537
load_classes do
36-
require 'smart_proxy_dynflow'
3738
require 'smart_proxy_remote_execution_ssh/version'
3839
require 'smart_proxy_remote_execution_ssh/cockpit'
3940
require 'smart_proxy_remote_execution_ssh/api'

0 commit comments

Comments
 (0)