Fix v3/v4 navigation to non-existent page and mobile sidebar in dark mode (#1068)

* Fix menu dark mode in responsive

* Added a bit of padding to the footer and changed v4 link

* Formatted MD files

* Added until to faq

* Added until to faq

* Fix #1058 Guide navigation links don't work if the same page does not exist on other guide.

Author: taras

CODE_OF_CONDUCT.md

@@ -2,45 +2,73 @@
 
 ## Our Pledge
 
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of
+experience, nationality, personal appearance, race, religion, or sexual identity
+and orientation.
 
 ## Our Standards
 
-Examples of behavior that contributes to creating a positive environment include:
+Examples of behavior that contributes to creating a positive environment
+include:
 
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
+- Using welcoming and inclusive language
+- Being respectful of differing viewpoints and experiences
+- Gracefully accepting constructive criticism
+- Focusing on what is best for the community
+- Showing empathy towards other community members
 
 Examples of unacceptable behavior by participants include:
 
-* The use of sexualized language or imagery and unwelcome sexual attention or advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a professional setting
+- The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+- Trolling, insulting/derogatory comments, and personal or political attacks
+- Public or private harassment
+- Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+- Other conduct which could reasonably be considered inappropriate in a
+  professional setting
 
 ## Our Responsibilities
 
-Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
 
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+Project maintainers have the right and responsibility to remove, edit, or reject
+comments, commits, code, wiki edits, issues, and other contributions that are
+not aligned to this Code of Conduct, or to ban temporarily or permanently any
+contributor for other behaviors that they deem inappropriate, threatening,
+offensive, or harmful.
 
 ## Scope
 
-This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at [email protected]. The project team
+will review and investigate all complaints, and will respond in a way that it
+deems appropriate to the circumstances. The project team is obligated to
+maintain confidentiality with regard to the reporter of an incident. Further
+details of specific enforcement policies may be posted separately.
 
-Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage],
+version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
 
 [homepage]: http://contributor-covenant.org
 [version]: http://contributor-covenant.org/version/1/4/

README.md

@@ -20,15 +20,16 @@ solid _at scale_, and it does all of this while feeling like normal JavaScript.
 ## Platforms
 
 Effection runs on all major JavaScript platforms including NodeJs, Browser, and
-Deno. It is published on both [npm][npm-effection] and [deno.land][deno-land-effection].
+Deno. It is published on both [npm][npm-effection] and
+[deno.land][deno-land-effection].
 
 ## Contributing to Website
 
 Go to [website's readme](www) to learn how to contribute to the website.
 
 ## Development
 
-[Deno][] is the primary tool used for development, testing, and packaging.
+[Deno][Deno] is the primary tool used for development, testing, and packaging.
 
 ### Testing
 
@@ -44,7 +45,7 @@ If you want to build a development version of the NPM package so that you can
 link it locally, you can use the `build:npm` script and passing it a version
 number. for example:
 
-``` text
+```text
 $ deno task build:npm 3.0.0-mydev-snapshot.0
 Task build:npm deno run -A tasks/build-npm.ts "3.0.0-mydev-snapshot.0"
 [dnt] Transforming...

docs/faq.mdx

@@ -41,7 +41,7 @@ Object.defineProperty(Promise.prototype, Symbol.iterator, {
 
 ## Why can't I use `call(Promise.resolve(42))` anymore?
 
-In Effection v3, it was possible to `yield* call(Promise.resolve(42))` but we removed this in Effection v4
-because we wanted to align call closer to `Function.prototype.call`. You can still use 
-`yield* call(() => Promise.resolve(42))` and `yield* call(async function() {})`. In v4, we plan to ship 
-a new function called `when` which will take a promise and wrap it in a constructor for convenience. 
+[until()](/api/v4/until) function offers a convenient alternative to passing a promise to `call`. In Effection v3, it was possible 
+to `yield* call(Promise.resolve(42))` but we removed this in Effection v4 because we wanted to align call closer 
+to `Function.prototype.call`. You can still use `yield* call(() => Promise.resolve(42))` and 
+`yield* call(async function() {})`.

www/components/footer.tsx

@@ -2,7 +2,7 @@ import { IconExternal } from "./icons/external.tsx";
 
 export function Footer(): JSX.Element {
   return (
-    <footer class="grid grid-cols-3 text-center text-gray-500 tracking-wide bg-gray-100 dark:bg-gray-900 dark:text-gray-400 py-8 gap-y-4 leading-8 justify-self-end">
+    <footer class="grid grid-cols-3 text-center text-gray-500 tracking-wide bg-gray-100 dark:bg-gray-900 dark:text-gray-400 py-8 gap-y-4 leading-8 justify-self-end px-5">
       <section class="flex flex-col gap-y-1">
         <h1 class="text-sm uppercase font-bold text-blue-primary dark:text-blue-secondary mb-4">
           About
@@ -15,9 +15,9 @@ export function Footer(): JSX.Element {
         </a>
         <a
           class="text-gray-800 dark:text-gray-200"
-          href="https://frontside.com/blog/2023-12-18-announcing-effection-v3/"
+          href="https://frontside.com/blog/2025-12-23-announcing-effection-v4/"
         >
-          Effection v3 Release Post <IconExternal />
+          Effection v4 Release Post <IconExternal />
         </a>
       </section>
       <section class="flex flex-col gap-y-1">

www/routes/guides-route.tsx

@@ -113,13 +113,13 @@ export function guidesRoute({
 
       const versionToggle = yield* all(
         SERIES.map(function* (s) {
+          const target = yield* useGuides(s);
+          const targetPage = yield* target.get(page.id);
+          const base = current === s ? "docs" : `guides/${s}`;
+          const url = yield* createRootUrl(base)(targetPage ? page.id : '/') ;
           return (
             <a
-              href={
-                yield* createRootUrl(current === s ? "docs" : `guides/${s}`)(
-                  page.id,
-                )
-              }
+              href={url}
               class={`text-base ${s === series ? "font-bold text-sky-500" : "text-gray-600 dark:text-gray-400 hover:text-sky-500"}`}
             >
               {s}
@@ -136,7 +136,7 @@ export function guidesRoute({
               id="docbar"
               class="fixed top-0 h-full w-full grid grid-cols-2 md:hidden bg-white dark:bg-gray-900 dark:text-gray-200"
             >
-              <nav class="bg-white p-2 border-r-2 h-full pt-24 min-h-0 h-full overflow-auto">
+              <nav class="bg-white dark:bg-gray-900 p-2 border-r-2 dark:border-gray-700 pt-24 min-h-0 h-full overflow-auto">
                 {topicsList}
               </nav>
               <label
@@ -153,7 +153,7 @@ export function guidesRoute({
     `}
               </style>
             </aside>
-            <aside class="min-h-0 overflow-auto hidden md:block top-[120px] sticky h-fit bg-white dark:bg-gray-900 dark:text-gray-200">
+            <aside class="min-h-0 overflow-auto hidden md:block top-30 sticky h-fit bg-white dark:bg-gray-900 dark:text-gray-200">
               <div class="text-xl flex flex-row items-baseline space-x-2 mb-3">
                 <>
                   <span class="font-bold">Guides</span>