Skip to content

Commit bcfe46f

Browse files
authored
Merge pull request #118 from thefrontside/tm/minor-cleanup
Minor cleanup: Fix README and converge test flakiness
2 parents c671a75 + 709e574 commit bcfe46f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ node --env-file=../.env --test "*.test.ts"
8383
"scripts": {
8484
"test": "node --env-file=../.env --test \"*.test.ts\""
8585
},
86-
"dependencies": {
87-
"effection": "^3"
88-
}
86+
"peerDependencies": {
87+
"effection": "^3 || ^4"
88+
}
8989
}
9090
```
9191

@@ -106,7 +106,7 @@ node --env-file=../.env --test "*.test.ts"
106106

107107
4. Add your package to `pnpm-workspace.yaml`
108108
5. Add your package to `tsconfig.json` references
109-
6. Run `pnpm sync:tsrefs:fix` to update dependencies
109+
6. Run `pnpm sync:fix` to update dependencies
110110
7. Add a `README.md` (text before `---` will be used as a description)
111111
8. Add your source code and export it from `mod.ts`
112112
9. Add doc strings to your source code - they will be used for documentation

converge/converge.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ describe("@effectionx/converge", () => {
225225
expect(stats.end).toBeGreaterThanOrEqual(end - 5);
226226
expect(stats.end).toBeLessThanOrEqual(end);
227227
expect(stats.elapsed).toBeGreaterThanOrEqual(50);
228-
expect(stats.runs).toBeGreaterThanOrEqual(4); // ~50ms / 10ms interval = ~5 runs, allow for timing variance
228+
expect(stats.runs).toBeGreaterThanOrEqual(3); // ~50ms / 10ms interval = ~5 runs, allow for timing variance on slower CI
229229
expect(stats.timeout).toEqual(50);
230230
expect(stats.interval).toEqual(10);
231231
expect(stats.value).toEqual(50);

0 commit comments

Comments
 (0)