refine types, run tsc for server and auth0 (#329)

* refine types, run tsc for server and auth0

* change file

* type check example repos as well

* remove expect-errors, resolve some cyclical types in GH sim

Author: jbolda

.changes/refine-tsc-with-safety-and-strictness.md

@@ -0,0 +1,8 @@
+---
+"@simulacrum/server": patch:enhance
+"@simulacrum/foundation-simulator": patch:enhance
+"@simulacrum/auth0-simulator": patch:enhance
+"@simulacrum/github-api-simulator": patch:enhance
+---
+
+Add additional TypeScript configure in workspace to further refine type checks. Run `tsc` in CI for every package.

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}

package-lock.json

@@ -11,7 +11,8 @@
     "test:watch": "NODE_EXTRA_CA_CERTS=\"$(mkcert -CAROOT)/rootCA.pem\" vitest watch --fileParallelism=false",
     "prepack": "npm run build",
     "build": "tsdown",
-    "lint": "echo noop"
+    "lint": "echo noop",
+    "tsc": "tsc --noEmit"
   },
   "repository": {
     "type": "git",

packages/auth0/package.json

@@ -1,5 +1,5 @@
 export const PRIVATE_KEY =
-  "-----BEGIN RSA PRIVATE KEY-----~~MIIEpAIBAAKCAQEAwzwwEqR5p7a6CaG61i3od+GLTyype3t/f0pwwtoA9NsZANcj~~HaAUR/qzqlNRQlLI687vF1OfbETYLeHIT5V36QGrMfrYR/tYAoaKFixC/wOjt8EB~~PoeHgaTOAyGf3V3YNwocNU+StyV1X4hPmDjCrapNYpbKIcAJwq5Ij0WBKGNXBcUU~~bAceRtLqgzf/6x2vcQJeE5nJK5gd41f/jtlK9Xge0Ig6CcdKOI7U3agyI/iNF3SL~~0bnCfvtDRIkgAzzeN5Yj4S3Z4rJVQ1RgzZmqBmnjw8h06G8wDyaQPf19u4F///gF~~+dL1md/fVRKL5UL7OZg42hIZzwzdhrxOGcXUFQIDAQABAoIBAQCSwHUqLjO722Av~~yT/VqqBpLEI4+0tSJFyL4/qqnI/HfcFnnk8o/6D/EfVm/EXCYtPgXKXflN3q1jzh~~ECwvlhySKszyPqnAQa/ABj1ZuV+KrMOtZgh3Zgx3aNfqBqZSES5rANB/ShbwT9nQ~~O3gI5fF/9NlCWDIL+HvduH+WIhqZrfHbTQrntr0sMvYTNE8PkAsB1GGZ5VO8gGGT~~Tg3kKOpNGWAJUYape/1Mb0Z1W8E1YDEaQKCnVY+Whr3+ZuLveDmyTuvLrUi+MAA4~~EaISkBZQo3ehUMjXm/0PdG4U9f2otAOhdwa2eT9irTkNS0TU+bi7VDEEhTmRKyfO~~yyVAGzTpAoGBAOmPbnMBAJYLk0SiQVspxIT+LW3tDWc7aFr/TtqAXkEVxI2xG6wA~~dEyRasBbPJDSWEljMre4g/6GG1fsPj0l5n2S8azy6jIu49ANvZPrrrBsuVYStR18~~MibzxjWWUht3vOCZBKtbqgHbC/oc49jMLPO5XrDFMTJPU5GkWRRLRZArAoGBANX+~~H6NQ7fUg8TUerXEB1WqA+FH4zVqJ/NKjbqaj9FPFWG59AjBVqQ335QzDWNCs/LjD~~REF/6qMeP2adehNhEVv2nK3rS+po9b4yLkiSysLivFPry9AxMGzFr3XzgoDb+y+y~~T02zj2k7nkGlNSSSanIxsp+TzTKsIY7ZbGx6d8y/AoGAS/kSDmq3DBe70cmNxN+z~~QyeDE4zWnUvfyCngNocnIbi49PY1cB+9tOJgfS2wZ9NkUIrqBoUIupRY9KKuJCnd~~7d8MqhtiPuytwhGWJzW030KejvcK3wp1LeKCCRBaqQCr+csMj8kDZhMgtD0NiInx~~3V3hBVM/i4PuRSPWrhlGCX0CgYEAq/xR8TBaD2kqc0b0np6ap75/1WHhqaK9T42K~~oOOkuq8hI6vU1oQCGvfhXyChgRWHB/foI7xrGC53RkHKm0ioawEJa75whTVWTEaI~~bEuOKpOQSOJ6LBlckg9PtbzAZlBm0S6+DfUCjdEcoCXnUD1cz+qhZR+lC9TMI8Mb~~IRRMtIECgYBrVlenf/rHK1UMC3FDmkOzH7agShcDHqzFMR1/NcMDolZNXXFy/u4t~~nDxci1smAUQr4oNs1lk9UzCdt0+pVCjmhbriBngwsS6sazOesDft53w6RTczsRpa~~09YDfcXhnI5yT+vd5r4xA5HhyniY7W1ahSzGDYIGlVm5IReC3P6Caw==~~-----END RSA PRIVATE KEY-----~~";
+  "-----BEGIN RSA PRIVATE KEY-----~~MIIEpAIBAAKCAQEAwzwwEqR5p7a6CaG61i3od+GLTyype3t/f0pwwtoA9NsZANcj~~HaAUR/qzqlNRQlLI687vF1OfbETYLeHIT5V36QGrMfrYR/tYAoaKFixC/wOjt8EB~~PoeHgaTOAyGf3V3YNwocNU+StyV1X4hPmDjCrapNYpbKIcAJwq5Ij0WBKGNXBcUU~~bAceRtLqgzf/6x2vcQJeE5nJK5gd41f/jtlK9Xge0Ig6CcdKOI7U3agyI/iNF3SL~~0bnCfvtDRIkgAzzeN5Yj4S3Z4rJVQ1RgzZmqBmnjw8h06G8wDyaQPf19u4F///gF~~+dL1md/fVRKL5UL7OZg42hIZzwzdhrxOGcXUFQIDAQABAoIBAQCSwHUqLjO722Av~~yT/VqqBpLEI4+0tSJFyL4/qqnI/HfcFnnk8o/6D/EfVm/EXCYtPgXKXflN3q1jzh~~ECwvlhySKszyPqnAQa/ABj1ZuV+KrMOtZgh3Zgx3aNfqBqZSES5rANB/ShbwT9nQ~~O3gI5fF/9NlCWDIL+HvduH+WIhqZrfHbTQrntr0sMvYTNE8PkAsB1GGZ5VO8gGGT~~Tg3kKOpNGWAJUYape/1Mb0Z1W8E1YDEaQKCnVY+Whr3+ZuLveDmyTuvLrUi+MAA4~~EaISkBZQo3ehUMjXm/0PdG4U9f2otAOhdwa2eT9irTkNS0TU+bi7VDEEhTmRKyfO~~yyVAGzTpAoGBAOmPbnMBAJYLk0SiQVspxIT+LW3tDWc7aFr/TtqAXkEVxI2xG6wA~~dEyRasBbPJDSWEljMre4g/6GG1fsPj0l5n2S8azy6jIu49ANvZPrrrBsuVYStR18~~MibzxjWWUht3vOCZBKtbqgHbC/oc49jMLPO5XrDFMTJPU5GkWRRLRZArAoGBANX+~~H6NQ7fUg8TUerXEB1WqA+FH4zVqJ/NKjbqaj9FPFWG59AjBVqQ335QzDWNCs/LjD~~REF/6qMeP2adehNhEVv2nK3rS+po9b4yLkiSysLivFPry9AxMGzFr3XzgoDb+y+y~~T02zj2k7nkGlNSSSanIxsp+TzTKsIY7ZbGx6d8y/AoGAS/kSDmq3DBe70cmNxN+z~~QyeDE4zWnUvfyCngNocnIbi49PY1cB+9tOJgfS2wZ9NkUIrqBoUIupRY9KKuJCnd~~7d8MqhtiPuytwhGWJzW030KejvcK3wp1LeKCCRBaqQCr+csMj8kDZhMgtD0NiInx~~3V3hBVM/i4PuRSPWrhlGCX0CgYEAq/xR8TBaD2kqc0b0np6ap75/1WHhqaK9T42K~~oOOkuq8hI6vU1oQCGvfhXyChgRWHB/foI7xrGC53RkHKm0ioawEJa75whTVWTEaI~~bEuOKpOQSOJ6LBlckg9PtbzAZlBm0S6+DfUCjdEcoCXnUD1cz+qhZR+lC9TMI8Mb~~IRRMtIECgYBrVlenf/rHK1UMC3FDmkOzH7agShcDHqzFMR1/NcMDolZNXXFy/u4t~~nDxci1smAUQr4oNs1lk9UzCdt0+pVCjmhbriBngwsS6sazOesDft53w6RTczsRpa~~09YDfcXhnI5yT+vd5r4xA5HhyniY7W1ahSzGDYIGlVm5IReC3P6Caw==~~-----END RSA PRIVATE KEY-----~~" as const;
 
 export const JWKS = {
   keys: [
@@ -12,4 +12,4 @@ export const JWKS = {
       use: "sig",
     },
   ],
-};
+} as const;

packages/auth0/src/auth/constants.ts

@@ -18,8 +18,9 @@ function getPort({ domain, port }: Auth0Configuration): number {
   }
 
   if (domain) {
-    if (domain.split(":").length === 2) {
-      return parseInt(domain.split(":")[1]);
+    const parts = domain.split(":");
+    if (parts.length === 2) {
+      return parseInt(parts[1]!);
     }
   }
 

packages/auth0/src/config/get-config.ts

@@ -268,33 +268,37 @@ export const createAuth0Handlers = (
       res.status(200).json(userinfo);
     },
 
-    ["/passwordless/start"]: async function (req, res, next) {
+    ["/passwordless/start"]: function (req, res, next) {
       logger.log({ "/passwordless/start": { body: req.body } });
 
       try {
         const { client_id, connection, email, phone_number, send } = req.body;
 
         // Validate required fields
         if (!client_id) {
-          return res.status(400).json({ error: "client_id is required" });
+          res.status(400).json({ error: "client_id is required" });
+          return;
         }
 
         if (!connection || (connection !== "email" && connection !== "sms")) {
-          return res.status(400).json({
+          res.status(400).json({
             error: "connection must be 'email' or 'sms'",
           });
+          return;
         }
 
         if (connection === "email" && !email) {
-          return res.status(400).json({
+          res.status(400).json({
             error: "email is required when connection is 'email'",
           });
+          return;
         }
 
         if (connection === "sms" && !phone_number) {
-          return res.status(400).json({
+          res.status(400).json({
             error: "phone_number is required when connection is 'sms'",
           });
+          return;
         }
 
         // Return appropriate response based on connection type

packages/auth0/src/handlers/auth0-handlers.ts

@@ -7,12 +7,9 @@ import { defaultErrorHandler } from "../middleware/error-handling.ts";
 import { createAuth0Handlers } from "./auth0-handlers.ts";
 import { createOpenIdHandlers } from "./openid-handlers.ts";
 import path from "path";
-import { fileURLToPath } from "url";
-import { Auth0Configuration } from "../types.ts";
+import { type Auth0Configuration } from "../types.ts";
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const publicDir = path.join(__dirname, "..", "views", "public");
+const publicDir = path.join(import.meta.dirname, "..", "views", "public");
 export const extendRouter =
   (config: Auth0Configuration, debug = false) =>
   (router: Express, simulationStore: ExtendedSimulationStore) => {

packages/auth0/src/handlers/index.ts

@@ -18,8 +18,8 @@ import {
   createRefreshToken,
   issueRefreshToken,
 } from "../auth/refresh-token.ts";
-import { ExtendedSimulationStore } from "../store/index.ts";
-import { Auth0User } from "../store/entities.ts";
+import { type ExtendedSimulationStore } from "../store/index.ts";
+import { type Auth0User } from "../store/entities.ts";
 
 export const createTokens = async ({
   body,

packages/auth0/src/handlers/oauth-handlers.ts

@@ -1,7 +1,7 @@
 import type { RequestHandler } from "express";
 import { assert } from "assert-ts";
 import { encode } from "base64-url";
-import type { QueryParams } from "src/types";
+import type { QueryParams } from "../types.ts";
 import { webMessage } from "../views/web-message.ts";
 
 export const createWebMessageHandler = (): RequestHandler =>