add tests for 3 main cases

Author: jbolda

packages/server/src/service.ts

@@ -60,12 +60,16 @@ export function useService(
         }
       }
 
-      const waiting = options.wellnessCheck.timeout
-        ? timebox(options.wellnessCheck.timeout, untilWell)
-        : untilWell();
-      const checked = yield* waiting;
-      if (options.wellnessCheck.timeout && checked && checked.timeout) {
+      if (options.wellnessCheck.timeout) {
+        const checked = yield* timebox(
+          options.wellnessCheck.timeout,
+          untilWell
+        );
+        if (checked && checked.timeout) {
         throw new Error("service wellness check timed out");
+        }
+      } else {
+        yield* untilWell();
       }
     }
 

packages/server/test/service.test.ts

@@ -1,4 +1,4 @@
-import { it } from "node:test";
+import { describe, it } from "node:test";
 import assert from "node:assert";
 import { useService } from "../src/service.ts";
 import { each, Err, Ok, run } from "effection";
@@ -16,24 +16,86 @@ it("test service", async () => {
   assert(assertionCount > 0);
 });
 
-it("test with wellness", async () => {
-  let assertionCount = 0;
-  await run(function* () {
-    yield* useService("test-service", nodeScriptWorks, {
-      wellnessCheck: {
-        timeout: 200,
-        *operation(stdio) {
-          for (let line of yield* each<string>(stdio)) {
-            if (line.includes("test service started")) {
-              return Ok<void>(void 0);
+describe("useService with wellness check", () => {
+  it("test with short wellness timeout", async () => {
+    let assertionCount = 0;
+    let errored = false;
+    await run(function* () {
+      yield* useService("test-service", nodeScriptWorks, {
+        wellnessCheck: {
+          timeout: 2,
+          *operation(stdio) {
+            for (let line of yield* each<string>(stdio)) {
+              console.log("wellness check got line:", { line });
+              if (line.includes("test service started")) {
+                return Ok<void>(void 0);
+              }
+              yield* each.next();
             }
-            yield* each.next();
-          }
-          return Err(new Error("got sick of waiting"));
+            return Err(new Error("got sick of waiting"));
+          },
         },
-      },
+      });
+      assertionCount++;
+    }).catch((error) => {
+      assert.equal(error.message, "service wellness check timed out");
+      errored = true;
+      assertionCount++;
     });
-    assertionCount++;
+    assert(assertionCount > 0);
+    assert(errored);
+  });
+
+  it("test with long wellness timeout", async () => {
+    let assertionCount = 0;
+    await run(function* () {
+      yield* useService("test-service", nodeScriptWorks, {
+        wellnessCheck: {
+          timeout: 2000,
+          *operation(stdio) {
+            for (let line of yield* each<string>(stdio)) {
+              console.log("wellness check got line:", { line });
+              if (line.includes("test service started")) {
+                return Ok<void>(void 0);
+              }
+              yield* each.next();
+            }
+            return Err(new Error("got sick of waiting"));
+          },
+        },
+      });
+      assertionCount++;
+    });
+    assert(assertionCount > 0);
+  });
+
+  it("test with mid-frequency wellness timeout", async () => {
+    let assertionCount = 0;
+    let errored = false;
+    await run(function* () {
+      yield* useService("test-service", nodeScriptWorks, {
+        wellnessCheck: {
+          timeout: 200,
+          frequency: 100,
+          *operation(stdio) {
+            for (let line of yield* each<string>(stdio)) {
+              console.log("wellness check got line:", { line });
+              if (line.includes("test service started")) {
+                return Ok<void>(void 0);
+              }
+              yield* each.next();
+            }
+            return Err(new Error("got sick of waiting"));
+          },
+        },
+      });
+      assertionCount++;
+    }).catch((error) => {
+      assert.equal(error.message, "service wellness check timed out");
+      errored = true;
+      assertionCount++;
+    });
+    assert(assertionCount > 0);
+    assert(errored);
   });
-  assert(assertionCount > 0);
 });