Fix lua errors (#2225)

* Fix lua errors

* Also fix getQuotaAverage for e2

Author: thegrb93

lua/starfall/editor/tabhandlers/tab_wire.lua

@@ -3070,12 +3070,13 @@ end
 
 function PANEL:AutocompleteApply()
 	local selection = self.acPanel:GetSelected()
-	self:SetCaret(self:SetArea({{self.Caret[1], math.max(1, self.Caret[2]-selection.replacelength)}, self.Caret }, selection.replace ))
-	if selection.reopen then
-		self:AutocompleteOpen()
-	else
-		self:AutocompleteClose()
+	if selection then
+		self:SetCaret(self:SetArea({{self.Caret[1], math.max(1, self.Caret[2]-selection.replacelength)}, self.Caret }, selection.replace ))
+		if selection.reopen then
+			return self:AutocompleteOpen()
+		end
 	end
+	self:AutocompleteClose()
 end
 
 function PANEL:AutocompleteClose()

lua/starfall/libs_sh/entities.lua

@@ -1087,7 +1087,7 @@ function ents_methods:getQuotaAverage()
 	if ent_tbl.Starfall then
 		return ent_tbl.instance and ent_tbl.instance:movingCPUAverage() or 0
 	elseif Ent_GetClass(ent)=="gmod_wire_expression2" then
-		return SERVER and ent_tbl.context.timebench or ent_tbl.GetOverlayData(ent).timebench
+		return SERVER and (ent_tbl.context and ent_tbl.context.timebench or 0) or (ent_tbl.GetOverlayData(ent).timebench or 0)
 	else
 		SF.Throw("The entity isn't a starfall or expression2 chip", 2)
 	end

lua/starfall/libs_sh/input.lua

@@ -98,11 +98,13 @@ hook.Add("FinishChat","SF_StartChat",function() isChatOpen=false end)
 
 local function CheckButtonPerms(instance, ply, button)
 	if not IsFirstTimePredicted() and not game.SinglePlayer() then return false end
-	if not haspermission(instance, nil, "input") then return false end
-	if isChatOpen and not haspermission(instance, nil, "input.chat") then
-		local notMouseButton = button < MOUSE_FIRST and button > MOUSE_LAST
-		local notJoystick = button < JOYSTICK_FIRST and button > JOYSTICK_LAST
-		if notMouseButton and notJoystick then return false end -- Mouse and joystick are allowed, they don't put text into the chat
+	if instance.player ~= SF.Superuser then
+		if not haspermission(instance, nil, "input") then return false end
+		if isChatOpen and not haspermission(instance, nil, "input.chat") then
+			local notMouseButton = button < MOUSE_FIRST and button > MOUSE_LAST
+			local notJoystick = button < JOYSTICK_FIRST and button > JOYSTICK_LAST
+			if notMouseButton and notJoystick then return false end -- Mouse and joystick are allowed, they don't put text into the chat
+		end
 	end
 
 	return true, { button }
@@ -129,7 +131,7 @@ SF.hookAdd(PlayerButtonUp, "inputreleased", CheckButtonPerms)
 -- @param string bind Name of keybind pressed
 -- @return boolean Returning true will block the binding from being pressed for the chip owner
 SF.hookAdd("PlayerBindPress", "inputbindpressed", function(instance, ply, bind)
-	if haspermission(instance, nil, "input") then
+	if instance.player == SF.Superuser or haspermission(instance, nil, "input") then
 		return true, {bind}
 	end
 	return false
@@ -145,7 +147,7 @@ end)
 -- @param number x X coordinate moved
 -- @param number y Y coordinate moved
 SF.hookAdd("InputMouseApply", "mousemoved", function(instance, _, x, y)
-	if haspermission(instance, nil, "input") then
+	if instance.player == SF.Superuser or haspermission(instance, nil, "input") then
 		if x~=0 or y~=0 then
 			return true, { x, y }
 		end
@@ -160,7 +162,7 @@ end)
 -- @class hook
 -- @param number delta Rotate delta
 SF.hookAdd("StartCommand", "mousewheeled", function(instance, ply, cmd)
-	if haspermission(instance, nil, "input") then
+	if instance.player == SF.Superuser or haspermission(instance, nil, "input") then
 		local delta = cmd:GetMouseWheel()
 		if delta ~= 0 then
 			return true, {delta}
@@ -175,7 +177,7 @@ local oldOnMouseWheeled = wpanel.OnMouseWheeled or function() end
 function wpanel:OnMouseWheeled(delta)
 	oldOnMouseWheeled(self, delta)
 	for inst, _ in pairs(SF.allInstances) do
-		if haspermission(inst, nil, "input") then
+		if inst.player == SF.Superuser or haspermission(inst, nil, "input") then
 			inst:runScriptHook("mousewheeled", delta)
 		end
 	end
@@ -257,7 +259,7 @@ function input_library.isKeyDown(key)
 	checkluatype(key, TYPE_NUMBER)
 
 	checkpermission(instance, nil, "input")
-	if isChatOpen and not haspermission(instance, nil, "input.chat") then return false end
+	if isChatOpen and not (instance.player == SF.Superuser or haspermission(instance, nil, "input.chat")) then return false end
 
 	return input.IsKeyDown(key)
 end
@@ -385,7 +387,7 @@ end
 -- @client
 -- @return boolean Whether the player's control can be locked
 function input_library.canLockControls()
-	return haspermission(instance, nil, "input.lockcontrols") and lockedControlCooldown + inputLockCooldown:GetFloat() <= CurTime()
+	return instance.player == SF.Superuser or (haspermission(instance, nil, "input.lockcontrols") and lockedControlCooldown + inputLockCooldown:GetFloat() <= CurTime())
 end
 
 --- Returns whether the game menu overlay ( main menu ) is open or not.