/sbin/record

[virmaior]

I'm not sure if this is a prduynt thing or a thingino thing, but doing minute long records, I am consistently losing about a second due to issues with the loop.

Currently testing the following changes to /sbin/record which reduces the frequency of the occupied space testing (which uses 0.2 seconds at least on my SD card):

check_so=0

while :; do
	[ -f $RECORD_FLAG ] || break
	get_free_space
	if [ "$available_space" -le "$required_space" ]; then
		log "Space required: $required_space KiB"
		log "Not enough space: $required_space > $available_space"
		while [ "$available_space" -le "$required_space" ]; do
			remove_oldest_file_in "$record_storage"
			get_free_space
			has_files "$record_storage" || die "$record_mount is empty yet no space!"
		done
	fi

if [ "$check_so" -le 0 ]; then
    if [ "$record_limit_kb" -gt 0 ]; then       
        log "Space limit: $record_limit_kb KiB"
        get_occupied_space                                                                   
	echo "$((occupied_space + (required_space * 100)))"
        if [ "$((occupied_space + (required_space * 100)))" -lt "$record_limit_kb" ]; then
   		log "lots of space - skipping check for 60 runs"
	         check_so=60
        fi                                               
        while [ "$((occupied_space + required_space))" -gt "$record_limit_kb" ]; do
            log "Occupied space $occupied_space KiB exceeds limit $record_limit_kb KiB"
            remove_oldest_file_in "$record_storage"                            
            get_occupied_space                      
            has_files "$record_storage" || die "$record_mount is empty yet no space!"
        done                                                      
    fi                                         
else                                 
    :$((check_so--))  # Modern decrement syntax, fixed indentation
fi


	record_file="$record_storage/$(date +"$record_filename").$record_videofmt"
	create_directory_for "$record_file"

        real_duration=$(fix_duration $record_duration)                                               
                                          
        log "openRTSP -u $rtsp_username $rtsp_password  -w $stream_width -h $stream_height -f $stream_fps -d $real_duration $vformat -b 1048576 -t rtsp://[::1]/$stream_endpoint > $record_file"
        openRTSP -u $rtsp_username $rtsp_password  -w $stream_width -h $stream_height -f $stream_fps \
                -d $real_duration $vformat -b 1048576 -t rtsp://[::1]/$stream_endpoint > "$record_file" 2> /dev/null
                                                   

	[ "true" = "$one_time" ] && rm $RECORD_FLAG
done

next step up that I'm thinking to implement is going to be make the space check daemon separate from the record daemon, because there's no reason why recording can't be happening while space checks are happening -- except in the case where there's not enough space for the file and the recording loop needs to pause.

Another idea:
modify the openRTSP package we can make it so that it keeps using the same stream and does the file segmentation according to the configuration file (default uses the same sort date based segmentation and can specify the segment size but cannot specify the filenames) This would emove some handshake overhead.

[virmaior]

I also get some sort of stutter in a lot of the videos at approximately every 10 seconds or so.

[virmaior]

the most relevant function inside openRTSP that determines the periodic file names is https://github.com/themactep/live555/blob/6d626de435a9d1e18ac247ba4ac2eba09aed4e7d/testProgs/playCommon.cpp#L997

it goes with %05d for the start and end time

This then gets passed into https://github.com/themactep/live555/blob/6d626de435a9d1e18ac247ba4ac2eba09aed4e7d/testProgs/playCommon.cpp#L997

[virmaior]

in with a pull request (#544) for using two daemons instead of one.