fix: HttpClient Error handling (#24)

Co-authored-by: awu <[email protected]>

Author: wundii

src/Stream/CurlMultiHandler.php

@@ -81,6 +81,9 @@ public function execute(): void
             if ($isRunning) {
                 curl_multi_select($multiHandle);
             }
+
+            $this->verifyCurlHandle($multiHandle);
+
         } while ($this->header->isEmpty() && $isRunning && $status === CURLM_OK);
 
         $this->multiHandle = $multiHandle;
@@ -111,6 +114,8 @@ public function contentIterator(): iterable
                 curl_multi_select($this->multiHandle);
             }
 
+            $this->verifyCurlHandle($this->multiHandle);
+
             while (!$this->write->isEmpty()) {
                 yield $this->write->read();
             }
@@ -132,4 +137,21 @@ public function contentIterator(): iterable
         $this->header = null;
         $this->write = null;
     }
+
+    private function verifyCurlHandle(CurlMultiHandle $curlMultiHandle): void
+    {
+        $info = curl_multi_info_read($curlMultiHandle);
+        if ($info === false) {
+            return;
+        }
+
+        $handle = $info['handle'] ?? null;
+        if (!$handle instanceof CurlHandle) {
+            throw new RuntimeException('Internal HttpClient: cURL handle info read returned an invalid handle.');
+        }
+
+        if (curl_errno($handle) !== 0) {
+            throw new RuntimeException('Internal HttpClient: cURL handle execution failed with error: ' . curl_error($handle));
+        }
+    }
 }

tests/Stream/CurlMultiHandlerTest.php

@@ -10,9 +10,12 @@
 use Thenativeweb\Eventsourcingdb\Stream\CurlMultiHandler;
 use Thenativeweb\Eventsourcingdb\Stream\Queue;
 use Thenativeweb\Eventsourcingdb\Stream\Request;
+use Thenativeweb\Eventsourcingdb\Tests\ClientTestTrait;
 
 final class CurlMultiHandlerTest extends TestCase
 {
+    use ClientTestTrait;
+
     public function getPropertyValue(object $object, string $propertyName): mixed
     {
         $reflectionClass = new ReflectionClass($object);
@@ -21,6 +24,11 @@ public function getPropertyValue(object $object, string $propertyName): mixed
         return $reflectionProperty->getValue($object);
     }
 
+    public function removeLineBrakes(string $line): string
+    {
+        return preg_replace('/\r\n|\r|\n/', '', $line);
+    }
+
     public function testAbortInWithPositiveValue(): void
     {
         $curlMultiHandler = new CurlMultiHandler();
@@ -78,6 +86,41 @@ public function testExecuteThrowsIfHandleMissing(): void
         $curlMultiHandler->execute();
     }
 
+    public function testExecuteThrowsIfHostNotExists(): void
+    {
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessageMatches("#Internal HttpClient: cURL handle execution failed with error: Failed to connect to [^ ]+ port 1234 after \d+ ms: Couldn't connect to server#");
+
+        $host = $this->container->getHost();
+        $baseUrl = "http://{$host}:1234";
+
+        $request = new Request(
+            'GET',
+            $baseUrl,
+        );
+        $curlMultiHandler = new CurlMultiHandler();
+        $curlMultiHandler->addHandle($request);
+        $curlMultiHandler->execute();
+    }
+
+    public function testExecuteSendsRequestAndParsesHttpHeadersCorrectly(): void
+    {
+        $request = new Request(
+            'GET',
+            $this->container->getBaseUrl() . '/api/v1/ping',
+        );
+        $curlMultiHandler = new CurlMultiHandler();
+        $curlMultiHandler->addHandle($request);
+        $curlMultiHandler->execute();
+
+        $headerQueue = $curlMultiHandler->getHeaderQueue();
+
+        $this->assertGreaterThanOrEqual(8, $headerQueue->getIterator()->count());
+        $this->assertSame('HTTP/1.1 200 OK', $this->removeLineBrakes($headerQueue->read()));
+        $this->assertSame('Cache-Control: no-store, no-cache, must-revalidate, proxy-revalidate', $this->removeLineBrakes($headerQueue->read()));
+        $this->assertSame('Content-Type: application/json', $this->removeLineBrakes($headerQueue->read()));
+    }
+
     public function testContentIteratorThrowsIfMultiHandleMissing(): void
     {
         $this->expectException(RuntimeException::class);