fix linting

Author: atstaeff

eventsourcingdb/client.py

@@ -3,8 +3,7 @@
 from types import TracebackType
 from typing import TypeVar
 
-from eventsourcingdb.abstract_base_client import AbstractBaseClient
-
+from .abstract_base_client import AbstractBaseClient
 from .event.event import Event
 from .event.event_candidate import EventCandidate
 from .event.event_context import EventContext

eventsourcingdb/http_client/http_client.py

@@ -35,37 +35,30 @@ async def __aexit__(
     ) -> None:
         await self.close()
 
-    # Keep for backward compatibility
     async def initialize(self) -> None:
         self.__session = aiohttp.ClientSession()
 
-    # Keep for backward compatibility
     async def close(self):
         if self.__session is not None:
             await self.__session.close()
             self.__session = None
-        return None
 
     async def post(self, path: str, request_body: str) -> Response:
         if self.__session is None:
             raise CustomError()
 
         async def request_executor() -> Response:
-            # Vorbereitung
             url_path = url.join_segments(self.__base_url, path)
             headers = get_post_headers(self.__api_token)
 
-            # Request ausführen
             async_response = await self.__session.post(  # type: ignore
                 url_path,
                 data=request_body,
                 headers=headers,
             )
 
-            # Response erstellen
             response = Response(async_response)
 
-            # Split try block to have only one statement
             validated_response = None
             try:
                 validated_response = await validate_response(response)
@@ -86,20 +79,16 @@ async def get(
             raise CustomError()
 
         async def request_executor() -> Response:
-            # Vorbereitung
             url_path = url.join_segments(self.__base_url, path)
             headers = get_get_headers(self.__api_token, with_authorization)
 
-            # Request ausführen
             async_response = await self.__session.get(  # type: ignore
                 url_path,
                 headers=headers,
             )
 
-            # Response erstellen
             response = Response(async_response)
 
-            # Split try block to have only one statement
             validated_response = None
             try:
                 validated_response = await validate_response(response)

tests/shared/event/assert_event.py

@@ -1,4 +1,4 @@
-from eventsourcingdb.event.event import Event
+from typing import Any
 
 # pylint: disable=R0917
 # Reason: This method is expected to have many parameters
@@ -8,7 +8,7 @@
 
 
 def assert_event_equals(
-        event: Event,
+        event: Any,  # Use Any instead of "Event" for type annotation
         source: str,
         subject: str,
         type_: str,

tests/shared/start_local_http_server.py

@@ -43,30 +43,24 @@ async def start_local_http_server(attach_handlers: AttachHandlers) -> tuple[Clie
     server = multiprocessing.Process(target=LocalHttpServer.start, args=(local_http_server, ))
     server.start()
 
-    # Warte auf den Server, bis er bereit ist
     async def ping_app():
-        retry_count = 0
         max_retries = 5
         retry_delay = 0.5
 
         async with aiohttp.ClientSession() as session:
-            while retry_count < max_retries:
+            for _ in range(max_retries):
+                url = f"http://localhost:{local_http_server.port}/__python_test__/api/v1/ping"
+                response = None
                 try:
-                    await session.get(
-                        f"http://localhost:{local_http_server.port}/__python_test__/api/v1/ping",
-                    )
-                    # Wenn die Anfrage erfolgreich ist, brechen wir die Schleife ab
-                    return True
+                    response = await session.get(url)
                 except (aiohttp.ClientError, asyncio.TimeoutError):
-                    retry_count += 1
                     await asyncio.sleep(retry_delay)
-
-            # Wenn alle Versuche fehlschlagen, geben wir False zurück
+                    continue
+                if response:
+                    return True
             return False
 
-    # Versuche, den Server zu erreichen
-    server_ready = await ping_app()
-    if not server_ready:
+    if not await ping_app():
         server.terminate()
         server.join()
         raise RuntimeError(f"Failed to start HTTP server on port {local_http_server.port}")

tests/test_register_event_schema.py

@@ -46,7 +46,6 @@ async def test_throws_error_if_schema_conflicts_with_existing_events(
             )
         ])
 
-        # Update the error pattern to match the actual error message about missing 'properties'
         with pytest.raises(ClientError, match="missing properties: 'properties'"):
             await client.register_event_schema(
                 "com.gornisht.ekht",
@@ -89,7 +88,6 @@ async def test_throws_error_if_schema_is_invalid(
     ):
         client = database.with_authorization.client
 
-        # Update the error pattern to match the actual error message about invalid type
         with pytest.raises(ClientError, match="value must be \"object\""):
             await client.register_event_schema(
                 "com.gornisht.ekht",
@@ -117,7 +115,7 @@ def handle_register_event_schema(response: Response) -> Response:
         client = await get_client(attach_handlers)
 
         with pytest.raises(ServerError):
-            await client.register_event_schema("com.foo.bar", '{"type":"object"}')
+            await client.register_event_schema("com.foo.bar", {"type": "object"})
 
     @staticmethod
     @pytest.mark.asyncio
@@ -136,7 +134,7 @@ def handle_register_event_schema(response: Response) -> Response:
         client = await get_client(attach_handlers)
 
         with pytest.raises(ClientError):
-            await client.register_event_schema("com.foo.bar", '{"type":"object"}')
+            await client.register_event_schema("com.foo.bar", {"type": "object"})
 
     @staticmethod
     @pytest.mark.asyncio
@@ -154,7 +152,7 @@ def handle_register_event_schema(response: Response) -> Response:
         client = await get_client(attach_handlers)
 
         with pytest.raises(ClientError):
-            await client.register_event_schema("com.foo.bar", '{"type":"object"}')
+            await client.register_event_schema("com.foo.bar", {"type": "object"})
 
     @staticmethod
     @pytest.mark.asyncio
@@ -174,4 +172,4 @@ def handle_register_event_schema(response: Response) -> Response:
         client = await get_client(attach_handlers)
 
         with pytest.raises(ServerError):
-            await client.register_event_schema("com.foo.bar", '{"type":"object"}')
+            await client.register_event_schema("com.foo.bar", {"type": "object"})