Skip to content

Commit 92ede47

Browse files
golorodenclaude
andcommitted
fix: resolve type checking error for DataFrame columns
Use conditional logic to create DataFrame with columns parameter only when the event list is empty, avoiding type checking issues with pyright while maintaining correct behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent e3e593f commit 92ede47

File tree

1 file changed

+20
-17
lines changed

1 file changed

+20
-17
lines changed

eventsourcingdb/pandas.py

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,6 @@ async def events_to_dataframe(events: AsyncGenerator[Event, None]) -> pd.DataFra
2020
Returns:
2121
A pandas DataFrame with all event fields as columns
2222
"""
23-
columns = [
24-
"event_id",
25-
"time",
26-
"source",
27-
"subject",
28-
"type",
29-
"data",
30-
"spec_version",
31-
"data_content_type",
32-
"predecessor_hash",
33-
"hash",
34-
"trace_parent",
35-
"trace_state",
36-
"signature",
37-
]
38-
3923
event_list = []
4024

4125
async for event in events:
@@ -56,4 +40,23 @@ async def events_to_dataframe(events: AsyncGenerator[Event, None]) -> pd.DataFra
5640
}
5741
event_list.append(event_dict)
5842

59-
return pd.DataFrame(event_list, columns=columns)
43+
if len(event_list) == 0:
44+
return pd.DataFrame(
45+
columns=[
46+
"event_id",
47+
"time",
48+
"source",
49+
"subject",
50+
"type",
51+
"data",
52+
"spec_version",
53+
"data_content_type",
54+
"predecessor_hash",
55+
"hash",
56+
"trace_parent",
57+
"trace_state",
58+
"signature",
59+
]
60+
)
61+
62+
return pd.DataFrame(event_list)

0 commit comments

Comments
 (0)