fix: QA linting issues

Author: atstaeff

eventsourcingdb_client_python/handlers/ping.py

@@ -1,18 +1,29 @@
 from http import HTTPStatus
 import json
-
 from ..abstract_base_client import AbstractBaseClient
 from ..errors.server_error import ServerError
 
+# Define constants for response values
+OK_RESPONSE = "OK"
+STATUS_OK = "ok"
+
 async def ping(client: AbstractBaseClient) -> None:
     response = await client.http_client.get('/api/v1/ping')
     response_body = bytes.decode(await response.body.read(), encoding='utf-8')
 
+    if response.status_code != HTTPStatus.OK:
+        raise ServerError(f'Received unexpected response: {response_body}')
+        
+    # Check old format (plain "OK")
+    if response_body == OK_RESPONSE:
+        return
+        
+    # Check new format (JSON {"status":"ok"})
     try:
         response_json = json.loads(response_body)
+        if isinstance(response_json, dict) and response_json.get('status') == STATUS_OK:
+            return
     except json.JSONDecodeError:
         pass
-    else:
-        if isinstance(response_json, dict) and response_json.get('status') == 'ok':
-            return None
-    raise ServerError(f'Received unexpected response: {response_body}')
+        
+    raise ServerError(f'Received unexpected response: {response_body}')

tests/shared/start_local_http_server.py

@@ -48,7 +48,7 @@ async def ping_app() -> RetryResult[None]:
         async with session:
             try:
                 response = await session.get(
-                    f'http://localhost:{local_http_server.port}/__python_test__/api/v1/ping', timeout=1
+                    f'http://localhost:{local_http_server.port}/__python_test__/api/v1/ping', timeout=aiohttp.ClientTimeout(total=1)
                 )
             except aiohttp.ClientError as error:
                 return Retry(cause=error)