fix: make access token mandatory (#28)

* chore: update test dockerfile

* chore: move access_token to positional parameters

* chore: formatting

---------

Co-authored-by: Golo Roden <[email protected]>

Author: Noah Hummel

eventsourcingdb_client_python/client.py

@@ -19,12 +19,13 @@ class Client(AbstractBaseClient):
     def __init__(
         self,
         base_url: str,
+        access_token: str,
         options: ClientOptions = ClientOptions()
     ):
         self.configuration: ClientConfiguration = ClientConfiguration(
             base_url=base_url,
             timeout_seconds=options.timeout_seconds,
-            access_token=options.access_token,
+            access_token=access_token,
             protocol_version=options.protocol_version,
             max_tries=options.max_tries
         )

eventsourcingdb_client_python/client_options.py

@@ -4,6 +4,5 @@
 @dataclass
 class ClientOptions:
     timeout_seconds: int = 10
-    access_token: str = ''
     protocol_version: str = '1.0.0'
     max_tries: int = 10

tests/shared/containerized_testing_database.py

@@ -10,19 +10,20 @@ def __init__(
         self,
         image: Image,
         command: [str],
+        access_token: str,
         options: ClientOptions = ClientOptions(),
     ):
         self.__command: [str] = command
         self.__image: Image = image
-        container, client = self.__start(options)
+        container, client = self.__start(access_token, options)
         self.__client: Client = client
         self.__container: Container = container
 
-    def __start(self, options: ClientOptions) -> (Container, Client):
+    def __start(self, access_token: str, options: ClientOptions) -> (Container, Client):
         container = self.__image.run(self.__command, True, True)
         exposed_port = container.get_exposed_port(3_000)
         base_url = f'http://127.0.0.1:{exposed_port}'
-        client = Client(base_url, options)
+        client = Client(base_url, access_token=access_token, options=options)
 
         client.ping()
 

tests/shared/database.py

@@ -16,10 +16,13 @@ def __init__(self):
         with_authorization = ContainerizedTestingDatabase(
             image,
             ['run', '--access-token', f'{access_token}', '--store-temporary'],
-            ClientOptions(access_token=access_token)
+            access_token,
+            ClientOptions()
         )
 
-        with_invalid_url = TestingDatabase(Client('http://localhost.invalid'))
+        with_invalid_url = TestingDatabase(
+            Client(base_url='http://localhost.invalid', access_token=access_token)
+        )
 
         self.with_authorization: ContainerizedTestingDatabase = with_authorization
         self.with_invalid_url: TestingDatabase = with_invalid_url